[PR #8] [MERGED] Add GPU regression results pages #9

New issue

Closed

opened 2026-10-31 22:05:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:05:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyci-dashboard/pull/8
Author: @marawan206
Created: 8/20/2026
Status: ✅ Merged
Merged: 8/21/2026
Merged by: @marawan206

Base: main ← Head: regression-results

📝 Commits (2)

9a7254b Add GPU regression results pages backed by GCS
729e14a Read regression results from the worker repo results branch

📊 Changes

10 files changed (+659 additions, -9 deletions)

View changed files

📝 .env.local.example (+4 -0)
📝 components/Header.tsx (+1 -0)
➕ components/MetricTable.tsx (+115 -0)
➕ components/RegressionBadge.tsx (+18 -0)
📝 next.config.js (+2 -0)
📝 pages/index.tsx (+19 -9)
➕ pages/regression/[branch]/[commit].tsx (+237 -0)
➕ pages/regression/index.tsx (+133 -0)
➕ src/regression/client.ts (+60 -0)
➕ src/regression/types.ts (+70 -0)

📄 Description

What this does

Adds read-only pages to the dashboard that surface the new GPU output-regression results for ComfyUI core master:

/regression — recent tested commits with per-workflow pass/fail badges and overall verdict.
/regression/[branch]/[commit] — per-workflow detail: comparison metrics vs the blessed golden baseline and vs the previous master run (MSE, PSNR, % pixels changed, max abs diff, thresholds used), with output images and diff heatmaps.
RegressionBadge / MetricTable components matching the existing Flowbite/Tailwind styling.

How it gets data

Purely static reads — no api.comfy.org changes. Results are published by the Comfy-Org/comfyci-runpod-worker pipeline (scheduled workflow tests each new master commit on a RunPod RTX 4090) to that repo's results branch, and the dashboard fetches the JSON/images from raw.githubusercontent.com with plain fetch + react-query. The base URL is overridable via NEXT_PUBLIC_REGRESSION_BASE (no Vercel env change needed now; when results move to GCS this is a one-var switch).

next.config.js adds raw.githubusercontent.com to the allowed image domains.

Notes for review

Stacked on #7 (dashboard-failure-visibility) — this PR shows only the regression commits; it retargets to main automatically once #7 merges.
No backend, auth, or write paths involved; the pages render "no data" states when results are missing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyci-dashboard/pull/8 **Author:** [@marawan206](https://github.com/marawan206) **Created:** 8/20/2026 **Status:** ✅ Merged **Merged:** 8/21/2026 **Merged by:** [@marawan206](https://github.com/marawan206) **Base:** `main` ← **Head:** `regression-results` --- ### 📝 Commits (2) - [`9a7254b`](https://github.com/Comfy-Org/comfyci-dashboard/commit/9a7254bd6b4492448a68c59db038e9d3a755bfd1) Add GPU regression results pages backed by GCS - [`729e14a`](https://github.com/Comfy-Org/comfyci-dashboard/commit/729e14a1bca08ee3f92bd3e5b28b5ac5d0431073) Read regression results from the worker repo results branch ### 📊 Changes **10 files changed** (+659 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.env.local.example` (+4 -0) 📝 `components/Header.tsx` (+1 -0) ➕ `components/MetricTable.tsx` (+115 -0) ➕ `components/RegressionBadge.tsx` (+18 -0) 📝 `next.config.js` (+2 -0) 📝 `pages/index.tsx` (+19 -9) ➕ `pages/regression/[branch]/[commit].tsx` (+237 -0) ➕ `pages/regression/index.tsx` (+133 -0) ➕ `src/regression/client.ts` (+60 -0) ➕ `src/regression/types.ts` (+70 -0) </details> ### 📄 Description ## What this does Adds read-only pages to the dashboard that surface the new GPU output-regression results for ComfyUI core master: - **`/regression`** — recent tested commits with per-workflow pass/fail badges and overall verdict. - **`/regression/[branch]/[commit]`** — per-workflow detail: comparison metrics vs the blessed golden baseline and vs the previous master run (MSE, PSNR, % pixels changed, max abs diff, thresholds used), with output images and diff heatmaps. - `RegressionBadge` / `MetricTable` components matching the existing Flowbite/Tailwind styling. ## How it gets data Purely static reads — no api.comfy.org changes. Results are published by the `Comfy-Org/comfyci-runpod-worker` pipeline (scheduled workflow tests each new master commit on a RunPod RTX 4090) to that repo's `results` branch, and the dashboard fetches the JSON/images from `raw.githubusercontent.com` with plain `fetch` + react-query. The base URL is overridable via `NEXT_PUBLIC_REGRESSION_BASE` (no Vercel env change needed now; when results move to GCS this is a one-var switch). `next.config.js` adds `raw.githubusercontent.com` to the allowed image domains. ## Notes for review - Stacked on #7 (`dashboard-failure-visibility`) — this PR shows only the regression commits; it retargets to `main` automatically once #7 merges. - No backend, auth, or write paths involved; the pages render "no data" states when results are missing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:05:58 +00:00