[PR #14] [MERGED] Land the merged regression history and triage pages (#12, #13) on main #14

New issue

Closed

opened 2026-10-31 22:06:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:06:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyci-dashboard/pull/14
Author: @marawan206
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @marawan206

Base: main ← Head: land-regression-pages

📝 Commits (10+)

953f41a feat(regression): add lane and run-index data contract
84aac26 feat(regression): turn the overview into a run history page
35e0093 fix(regression): drop the unused shard hook and blessed type
e552bd1 fix(regression): say which lane is shown for an unknown ?lane=
e340551 fix(regression): report failed fetches instead of an empty state
df86854 fix(regression): relax lane staleness and name unlisted branches
fc7063b fix(regression): count execution errors as open regressions
9754f8e fix(regression): share the overall badge and first-bad line
93183ca fix(regression): build compare links from the commit range
d63b8b7 fix(regression): close first-bad banners once the latest run passes

📊 Changes

20 files changed (+2085 additions, -164 deletions)

View changed files

➕ components/CommitMetaChip.tsx (+47 -0)
➕ components/FetchError.tsx (+36 -0)
➕ components/FirstBadLine.tsx (+91 -0)
➕ components/HistoryTable.tsx (+176 -0)
➕ components/LaneSelect.tsx (+86 -0)
📝 components/MetricTable.tsx (+24 -2)
➕ components/ReblessCallout.tsx (+66 -0)
📝 components/RegressionBadge.tsx (+81 -14)
➕ components/RegressionSummaryHeader.tsx (+203 -0)
➕ components/Sparkline.tsx (+56 -0)
➕ components/StaleBanner.tsx (+76 -0)
📝 components/StatsDashboard.tsx (+1 -1)
📝 components/StatusButton.tsx (+16 -2)
📝 package.json (+1 -1)
📝 pages/regression/[branch]/[commit].tsx (+233 -35)
📝 pages/regression/index.tsx (+478 -76)
📝 src/regression/client.ts (+192 -33)
📝 src/regression/types.ts (+145 -0)
➕ src/regression/validate.ts (+53 -0)
➕ utils/time.ts (+24 -0)

📄 Description

#12 and #13 were merged into their stacked base branches (regression-run-details, regression-history) rather than main, so main has #9 and #11 but not the history and triage pages. This PR brings the already-reviewed stack into main and contains no new changes.

The head is the current regression-triage, which contains:

#12: regression history from the published run index
#13: commit-page triage and the re-bless callout

Checks:

Nothing is lost. regression-run-details and regression-history contain no commits that regression-triage lacks.
It merges cleanly with main, including #11. components/StatsDashboard.tsx merges automatically.
On the merged result, tsc --noEmit and pnpm lint pass.

The history page reads the run index, which the worker starts updating on every run once Comfy-Org/comfyci-runpod-worker#7 merges.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyci-dashboard/pull/14 **Author:** [@marawan206](https://github.com/marawan206) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@marawan206](https://github.com/marawan206) **Base:** `main` ← **Head:** `land-regression-pages` --- ### 📝 Commits (10+) - [`953f41a`](https://github.com/Comfy-Org/comfyci-dashboard/commit/953f41ae4804331c1bfb0ea5c2df504d6b4fff7e) feat(regression): add lane and run-index data contract - [`84aac26`](https://github.com/Comfy-Org/comfyci-dashboard/commit/84aac265573e0911b70d3bbe2ead971dbcf24de2) feat(regression): turn the overview into a run history page - [`35e0093`](https://github.com/Comfy-Org/comfyci-dashboard/commit/35e00932d95ba65a0b696f75e9519c543e5a9e94) fix(regression): drop the unused shard hook and blessed type - [`e552bd1`](https://github.com/Comfy-Org/comfyci-dashboard/commit/e552bd1b24ff0a37c768714f292f5a2093c0bb88) fix(regression): say which lane is shown for an unknown ?lane= - [`e340551`](https://github.com/Comfy-Org/comfyci-dashboard/commit/e340551557e596f0e333d0b1a7263869ad3a773d) fix(regression): report failed fetches instead of an empty state - [`df86854`](https://github.com/Comfy-Org/comfyci-dashboard/commit/df8685466414656d49c3427d6cd3bf307ece59ec) fix(regression): relax lane staleness and name unlisted branches - [`fc7063b`](https://github.com/Comfy-Org/comfyci-dashboard/commit/fc7063bf50f7c7d63f40d830699fd78ccbd3fb16) fix(regression): count execution errors as open regressions - [`9754f8e`](https://github.com/Comfy-Org/comfyci-dashboard/commit/9754f8e73138f57adf8961cb2ef8337e9d6d5106) fix(regression): share the overall badge and first-bad line - [`93183ca`](https://github.com/Comfy-Org/comfyci-dashboard/commit/93183cab7cb8810214fceeac3bfe834db73bf424) fix(regression): build compare links from the commit range - [`d63b8b7`](https://github.com/Comfy-Org/comfyci-dashboard/commit/d63b8b7a73e1c466eadd5bc7cb180983ca26cfc5) fix(regression): close first-bad banners once the latest run passes ### 📊 Changes **20 files changed** (+2085 additions, -164 deletions) <details> <summary>View changed files</summary> ➕ `components/CommitMetaChip.tsx` (+47 -0) ➕ `components/FetchError.tsx` (+36 -0) ➕ `components/FirstBadLine.tsx` (+91 -0) ➕ `components/HistoryTable.tsx` (+176 -0) ➕ `components/LaneSelect.tsx` (+86 -0) 📝 `components/MetricTable.tsx` (+24 -2) ➕ `components/ReblessCallout.tsx` (+66 -0) 📝 `components/RegressionBadge.tsx` (+81 -14) ➕ `components/RegressionSummaryHeader.tsx` (+203 -0) ➕ `components/Sparkline.tsx` (+56 -0) ➕ `components/StaleBanner.tsx` (+76 -0) 📝 `components/StatsDashboard.tsx` (+1 -1) 📝 `components/StatusButton.tsx` (+16 -2) 📝 `package.json` (+1 -1) 📝 `pages/regression/[branch]/[commit].tsx` (+233 -35) 📝 `pages/regression/index.tsx` (+478 -76) 📝 `src/regression/client.ts` (+192 -33) 📝 `src/regression/types.ts` (+145 -0) ➕ `src/regression/validate.ts` (+53 -0) ➕ `utils/time.ts` (+24 -0) </details> ### 📄 Description #12 and #13 were merged into their stacked base branches (`regression-run-details`, `regression-history`) rather than `main`, so `main` has #9 and #11 but not the history and triage pages. This PR brings the already-reviewed stack into `main` and contains no new changes. The head is the current `regression-triage`, which contains: - #12: regression history from the published run index - #13: commit-page triage and the re-bless callout Checks: - Nothing is lost. `regression-run-details` and `regression-history` contain no commits that `regression-triage` lacks. - It merges cleanly with `main`, including #11. `components/StatsDashboard.tsx` merges automatically. - On the merged result, `tsc --noEmit` and `pnpm lint` pass. The history page reads the run index, which the worker starts updating on every run once Comfy-Org/comfyci-runpod-worker#7 merges. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:06:01 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfyci-dashboard#14

No description provided.

Rows
Columns