mirror of
https://github.com/Comfy-Org/comfyci-dashboard.git
synced 2026-11-04 23:47:28 +00:00
[PR #13] [MERGED] Explain regressions on the commit page and offer the re-bless flow #12
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/comfyci-dashboard#12
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/comfyci-dashboard/pull/13
Author: @marawan206
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @alexisrolland
Base:
regression-history← Head:regression-triage📝 Commits (9)
20958d8feat(regression): triage components for the commit page62c62b9feat(regression): lane-aware commit page with triage summary5997910fix(regression): tolerate commit metadata without parents67ce8bffix(regression): take inherited drift from the index only2c46d38fix(regression): keep the run's golden apart from the current golden58c50c1fix(regression): report failed fetches on the commit pageb74f54cfix(regression): explain execution errors in the triage summary32f9d8afix(regression): use the shared overall rule and first-bad linecdc94a6fix(regression): say which lane the commit page shows for an unknown ?lane=📊 Changes
8 files changed (+553 additions, -36 deletions)
View changed files
➕
components/CommitMetaChip.tsx(+43 -0)📝
components/LaneSelect.tsx(+30 -0)📝
components/MetricTable.tsx(+24 -2)➕
components/ReblessCallout.tsx(+60 -0)📝
components/RegressionBadge.tsx(+1 -1)➕
components/RegressionSummaryHeader.tsx(+199 -0)📝
pages/regression/[branch]/[commit].tsx(+194 -32)📝
src/regression/types.ts(+2 -1)📄 Description
Why
A failing commit page showed metrics and diff images but did not say what changed, by how much, against which baseline, or since when, and gave no way forward when the change was intentional (the current FLUX case: a kernel optimisation in #16488 moved every pixel by a rounding error and the v0.33.2 golden is simply stale).
What
On
pages/regression/[branch]/[commit].tsx:RegressionSummaryHeader: pass/fail counts; for each failing workflow one sentence against the golden it was judged by ("vs golden v0.33.2 (blessed 2026-08-20 by …): MSE 3.44 > 2, PSNR 42.8 dB < 45, 70.0% px > 1%; outputs unchanged vs previous run "), an "Inherited drift" label when the index says so, an amber "Accepted drift" badge when the output sha matches the lane's current golden, and a "failing since" line (commit, PR, author, N runs, compare link) from the index head. Execution errors are explained with the worker's status.CommitMetaChip: subject, author, committed date, PR and parent links fromsummary.commit_meta(falls back to the index entry, hidden when neither exists).?lane=) when more than one lane is published; every URL goes through the lane-aware path resolver.ReblessCallouton failing cards: explains the re-bless flow with a copyablegh workflow run golden-baseline.yml …command.MetricTable: optional noise-floor row ("golden re-run: identical / metrics").Stacked on #12 (shares
types.ts,client.ts,RegressionBadge,LaneSelect).Verification
pnpm lint: no warnings;pnpm build: all routes compile (checked from a clean worktree)./regression/master/2139131e880cf07116f0d0238de8cfbb125d2114reads "flux_dev_t2i vs golden v0.33.2: MSE 3.44 > 2, PSNR 42.8 dB < 45, 70.0% px > 1%; outputs unchanged vs previous run 7fbcfa8b" with "Inherited drift, failing since b5cc8830 (#16488, comfyanonymous)";/regression/master/b5cc8830279eae909a59de030af1e50761c36751shows the same commit as the first bad one with its diff figures; the sdxl card stays green.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.