[PR #11] [MERGED] Fix the legacy All Results and Waterfall pages and mark their data as legacy #11

New issue

Closed

opened 2026-10-31 22:06:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:06:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyci-dashboard/pull/11
Author: @marawan206
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @alexisrolland

Base: main ← Head: dashboard-hygiene

📝 Commits (6)

def4b36 Create the QueryClient once with cache defaults
53706c9 Add legacy CI banner, safe thumbnails and shared repo list
571b2bf Default legacy pages to Comfy-Org/ComfyUI and tighten filters
6056110 Drop the per-page date from the legacy banner
93cfa5d Describe the stats cards as per-page
b15804f Omit a blank branch when drilling from Waterfall into All Results

📊 Changes

9 files changed (+174 additions, -70 deletions)

View changed files

📝 components/Labels/ClearableLabel.tsx (+4 -1)
➕ components/LegacyBanner.tsx (+29 -0)
➕ components/SafeThumb.tsx (+36 -0)
📝 components/StatsDashboard.tsx (+2 -2)
📝 pages/_app.tsx (+5 -1)
📝 pages/index.tsx (+43 -17)
📝 pages/waterfall/index.tsx (+43 -44)
📝 pages/workflow/[id].tsx (+4 -5)
➕ src/legacy/repos.ts (+8 -0)

📄 Description

Why

All Results and Waterfall default to the repository name comfyanonymous/ComfyUI, whose api.comfy.org data ends on 2026-01-07; the data under Comfy-Org/ComfyUI runs to 2026-06-22, and nothing newer exists because the core GPU CI (comfy-action on the GCP runner) has not reported since then (push trigger disabled 2026-08-31). Every output thumbnail is a 404 because the GCS bucket is empty. The pages also had a handful of bugs: a new QueryClient on every render (refetch + spinner on every filter change), a blank branch option that sends branchName= and shows an empty page, a never-sent OS filter and two permanently disabled inputs on Waterfall, a drill-down that pushed an always-empty commit id, regression links that 404 for branches containing /, and no error state anywhere.

What

pages/_app.tsx: one QueryClient (60 s staleTime, one retry).
Default repo Comfy-Org/ComfyUI plus a repo select for both historical names (src/legacy/repos.ts), kept in sync with the ?repo= URL param.
components/LegacyBanner.tsx: amber banner on both pages stating that the legacy core GPU CI stopped reporting on 2026-06-22, thumbnails are unavailable, and current results live under Regression.
Error states on both pages (isError), components/SafeThumb.tsx with an onError fallback for the list thumbnails and the workflow hero image.
Waterfall: blank branch maps to undefined, dead OS filter and disabled inputs removed, drill-down passes the row's branch and platform only.
All Results: encoded regression links, Commit ID input labelled as the API's internal id, stats cards described as per page.

Verification

pnpm lint: no warnings; pnpm build: all routes compile (checked from a clean worktree).
On the Vercel preview: both pages show June 2026 data for Comfy-Org/ComfyUI with the banner; switching the repo select to comfyanonymous/ComfyUI shows the January data; Waterfall's "Select Branch" no longer blanks the page; a broken thumbnail renders the dashed placeholder.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyci-dashboard/pull/11 **Author:** [@marawan206](https://github.com/marawan206) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@alexisrolland](https://github.com/alexisrolland) **Base:** `main` ← **Head:** `dashboard-hygiene` --- ### 📝 Commits (6) - [`def4b36`](https://github.com/Comfy-Org/comfyci-dashboard/commit/def4b368e3d09411bbdfc9cafa01ccc8c6d8f903) Create the QueryClient once with cache defaults - [`53706c9`](https://github.com/Comfy-Org/comfyci-dashboard/commit/53706c990a645410bfc4ce002704ee12424d2067) Add legacy CI banner, safe thumbnails and shared repo list - [`571b2bf`](https://github.com/Comfy-Org/comfyci-dashboard/commit/571b2bf44408312d4ae363be7052365c6f3cbe39) Default legacy pages to Comfy-Org/ComfyUI and tighten filters - [`6056110`](https://github.com/Comfy-Org/comfyci-dashboard/commit/6056110e40db01409a5c85bd1a67b64bc2ef6d9c) Drop the per-page date from the legacy banner - [`93cfa5d`](https://github.com/Comfy-Org/comfyci-dashboard/commit/93cfa5d3b43abc15b06d77e068834ed36ecac1a6) Describe the stats cards as per-page - [`b15804f`](https://github.com/Comfy-Org/comfyci-dashboard/commit/b15804f66c088a6dbabbaca23604e659902c2224) Omit a blank branch when drilling from Waterfall into All Results ### 📊 Changes **9 files changed** (+174 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `components/Labels/ClearableLabel.tsx` (+4 -1) ➕ `components/LegacyBanner.tsx` (+29 -0) ➕ `components/SafeThumb.tsx` (+36 -0) 📝 `components/StatsDashboard.tsx` (+2 -2) 📝 `pages/_app.tsx` (+5 -1) 📝 `pages/index.tsx` (+43 -17) 📝 `pages/waterfall/index.tsx` (+43 -44) 📝 `pages/workflow/[id].tsx` (+4 -5) ➕ `src/legacy/repos.ts` (+8 -0) </details> ### 📄 Description ## Why All Results and Waterfall default to the repository name `comfyanonymous/ComfyUI`, whose api.comfy.org data ends on 2026-01-07; the data under `Comfy-Org/ComfyUI` runs to 2026-06-22, and nothing newer exists because the core GPU CI (comfy-action on the GCP runner) has not reported since then (push trigger disabled 2026-08-31). Every output thumbnail is a 404 because the GCS bucket is empty. The pages also had a handful of bugs: a new QueryClient on every render (refetch + spinner on every filter change), a blank branch option that sends `branchName=` and shows an empty page, a never-sent OS filter and two permanently disabled inputs on Waterfall, a drill-down that pushed an always-empty commit id, regression links that 404 for branches containing `/`, and no error state anywhere. ## What - `pages/_app.tsx`: one QueryClient (60 s staleTime, one retry). - Default repo `Comfy-Org/ComfyUI` plus a repo select for both historical names (`src/legacy/repos.ts`), kept in sync with the `?repo=` URL param. - `components/LegacyBanner.tsx`: amber banner on both pages stating that the legacy core GPU CI stopped reporting on 2026-06-22, thumbnails are unavailable, and current results live under Regression. - Error states on both pages (`isError`), `components/SafeThumb.tsx` with an onError fallback for the list thumbnails and the workflow hero image. - Waterfall: blank branch maps to undefined, dead OS filter and disabled inputs removed, drill-down passes the row's branch and platform only. - All Results: encoded regression links, Commit ID input labelled as the API's internal id, stats cards described as per page. ## Verification - `pnpm lint`: no warnings; `pnpm build`: all routes compile (checked from a clean worktree). - On the Vercel preview: both pages show June 2026 data for `Comfy-Org/ComfyUI` with the banner; switching the repo select to `comfyanonymous/ComfyUI` shows the January data; Waterfall's "Select Branch" no longer blanks the page; a broken thumbnail renders the dashed placeholder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:06:00 +00:00