[PR #29] [MERGED] build: bump ComfyUI to v0.30.0 so CI serves current workflow templates #28

New issue

Closed

opened 2026-10-26 22:23:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:23:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyui-ci-container/pull/29
Author: @christian-byrne
Created: 8/4/2026
Status: ✅ Merged
Merged: 8/4/2026
Merged by: @DrJKL

Base: main ← Head: christian/bump-comfyui-for-first-run-templates

📝 Commits (1)

34e62c5 build: bump ComfyUI to v0.30.0 so CI serves current workflow templates

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Dockerfile (+1 -1)

📄 Description

The image pins ARG COMFYUI_VERSION=v0.19.3, which installs comfyui-workflow-templates==0.9.57. That predates templates the frontend pins by id, so the e2e backend doesn't serve them.

Why this surfaced now

ComfyUI_frontend has a drift guard (browser_tests/tests/firstRunTourRolePins.spec.ts) that verifies the first-run tour's pinned templates are actually served. It asserted a count — toBeGreaterThan(2) against 8 pins — so six served passed and nothing was wrong. Tightening it to assert identity (Comfy-Org/ComfyUI_frontend#14670) immediately caught:

image_krea2_turbo_t2i — the first entry in CURATED_TEMPLATE_IDS and the inpaint tutorial card's thumbnail
templates-qwen_multiangle.app

The pins are correct; both exist upstream. The container is what's behind.

Verified directly against the templates package:

	`image_krea2_turbo_t2i` present?
templates 0.9.57 (ComfyUI v0.19.3, current image)	❌ 404
templates 0.11.19 (ComfyUI v0.29.0)	✅
templates 0.11.27 (ComfyUI v0.30.0)	✅

The template landed upstream 2026-07-21. All four CURATED_TEMPLATE_IDS are present in 0.11.27.

Why v0.30.0 rather than the minimum

v0.29.0 would be the smallest bump that fixes the immediate symptom (templates 0.11.19). I went to v0.30.0 — current latest — because the image is otherwise eleven minor versions behind, and a minimal bump leaves the same class of failure to recur within weeks.

That is the risk in this PR, and it should be weighed rather than assumed away: this is a large jump in the backend the whole frontend e2e suite runs against. If it destabilises those runs, v0.29.0 is the conservative fallback and still fixes the curated-template gap.

What I could not verify

I have not built or run this image. The consequence — whether ComfyUI v0.30.0 changes anything the frontend's Playwright suite depends on — is only observable once the image is published and the frontend points at it.

Sequence: merge here → new image tag published → bump the four ghcr.io/comfy-org/comfyui-ci-container:0.0.21 references in ComfyUI_frontend (ci-tests-e2e.yaml ×2, ci-perf-report.yaml, pr-update-playwright-expectations.yaml).

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyui-ci-container/pull/29 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 8/4/2026 **Status:** ✅ Merged **Merged:** 8/4/2026 **Merged by:** [@DrJKL](https://github.com/DrJKL) **Base:** `main` ← **Head:** `christian/bump-comfyui-for-first-run-templates` --- ### 📝 Commits (1) - [`34e62c5`](https://github.com/Comfy-Org/comfyui-ci-container/commit/34e62c5dcce2903080772a3cb05b8acef4c456dc) build: bump ComfyUI to v0.30.0 so CI serves current workflow templates ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -1) </details> ### 📄 Description The image pins `ARG COMFYUI_VERSION=v0.19.3`, which installs `comfyui-workflow-templates==0.9.57`. That predates templates the frontend pins by id, so the e2e backend doesn't serve them. ## Why this surfaced now `ComfyUI_frontend` has a drift guard (`browser_tests/tests/firstRunTourRolePins.spec.ts`) that verifies the first-run tour's pinned templates are actually served. It asserted a **count** — `toBeGreaterThan(2)` against 8 pins — so six served passed and nothing was wrong. Tightening it to assert identity (Comfy-Org/ComfyUI_frontend#14670) immediately caught: - **`image_krea2_turbo_t2i`** — the **first entry in `CURATED_TEMPLATE_IDS`** and the inpaint tutorial card's thumbnail - `templates-qwen_multiangle.app` The pins are correct; both exist upstream. The container is what's behind. Verified directly against the templates package: | | `image_krea2_turbo_t2i` present? | | --- | --- | | templates **0.9.57** (ComfyUI v0.19.3, current image) | ❌ 404 | | templates **0.11.19** (ComfyUI v0.29.0) | ✅ | | templates **0.11.27** (ComfyUI v0.30.0) | ✅ | The template landed upstream 2026-07-21. All four `CURATED_TEMPLATE_IDS` are present in 0.11.27. ## Why v0.30.0 rather than the minimum v0.29.0 would be the smallest bump that fixes the immediate symptom (templates 0.11.19). I went to v0.30.0 — current latest — because the image is otherwise **eleven minor versions behind**, and a minimal bump leaves the same class of failure to recur within weeks. **That is the risk in this PR, and it should be weighed rather than assumed away:** this is a large jump in the backend the whole frontend e2e suite runs against. If it destabilises those runs, v0.29.0 is the conservative fallback and still fixes the curated-template gap. ## What I could not verify I have not built or run this image. The consequence — whether ComfyUI v0.30.0 changes anything the frontend's Playwright suite depends on — is only observable once the image is published and the frontend points at it. Sequence: merge here → new image tag published → bump the four `ghcr.io/comfy-org/comfyui-ci-container:0.0.21` references in `ComfyUI_frontend` (`ci-tests-e2e.yaml` ×2, `ci-perf-report.yaml`, `pr-update-playwright-expectations.yaml`). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:23:03 +00:00