[PR #30] [MERGED] fix: update all frontend container references #30

New issue

Closed

opened 2026-10-26 22:23:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:23:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyui-ci-container/pull/30
Author: @DrJKL
Created: 8/10/2026
Status: ✅ Merged
Merged: 8/20/2026
Merged by: @DrJKL

Base: main ← Head: fix/sync-frontend-container-refs

📝 Commits (3)

97b06d8 fix: update all frontend container references
855abca fix: harden frontend container updates
95984c5 fix: run frontend updates after image builds

📊 Changes

2 files changed (+54 additions, -17 deletions)

View changed files

📝 .github/workflows/build-and-push.yml (+14 -0)
📝 .github/workflows/update-frontend-container-ref.yml (+40 -17)

📄 Description

Summary

Update every ComfyUI frontend container reference after a CI image publishes successfully.

Changes

Call the frontend updater from the successful image build instead of relying on tag events created by GITHUB_TOKEN.
Validate stable semver input and wait for the exact GHCR manifest before opening a PR.
Update the performance workflow and local/Amp launcher alongside the existing E2E workflows.
Run the frontend drift check after replacement when available.
Remain compatible until Comfy-Org/ComfyUI_frontend#14995 adds the launcher and checker.

Testing

Actionlint passes for update-frontend-container-ref.yml.
Both workflow files parse as YAML.
Simulated a 9.8.7 update against the frontend branch and ran its drift checker successfully.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyui-ci-container/pull/30 **Author:** [@DrJKL](https://github.com/DrJKL) **Created:** 8/10/2026 **Status:** ✅ Merged **Merged:** 8/20/2026 **Merged by:** [@DrJKL](https://github.com/DrJKL) **Base:** `main` ← **Head:** `fix/sync-frontend-container-refs` --- ### 📝 Commits (3) - [`97b06d8`](https://github.com/Comfy-Org/comfyui-ci-container/commit/97b06d822bd4501b065c9d938669700734cb940d) fix: update all frontend container references - [`855abca`](https://github.com/Comfy-Org/comfyui-ci-container/commit/855abca3477372a0678b83e4b19e986ccb712a21) fix: harden frontend container updates - [`95984c5`](https://github.com/Comfy-Org/comfyui-ci-container/commit/95984c5437c1948f9b45cadde73c34c1e89b4e4c) fix: run frontend updates after image builds ### 📊 Changes **2 files changed** (+54 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-and-push.yml` (+14 -0) 📝 `.github/workflows/update-frontend-container-ref.yml` (+40 -17) </details> ### 📄 Description ## Summary Update every ComfyUI frontend container reference after a CI image publishes successfully. ## Changes - Call the frontend updater from the successful image build instead of relying on tag events created by `GITHUB_TOKEN`. - Validate stable semver input and wait for the exact GHCR manifest before opening a PR. - Update the performance workflow and local/Amp launcher alongside the existing E2E workflows. - Run the frontend drift check after replacement when available. - Remain compatible until Comfy-Org/ComfyUI_frontend#14995 adds the launcher and checker. ## Testing - Actionlint passes for `update-frontend-container-ref.yml`. - Both workflow files parse as YAML. - Simulated a `9.8.7` update against the frontend branch and ran its drift checker successfully. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:23:04 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfyui-ci-container#30

No description provided.

Rows
Columns