Comfy-Org/cookiecutter-comfy-extension

Fork 0

mirror of https://github.com/Comfy-Org/cookiecutter-comfy-extension.git synced 2026-11-04 23:47:39 +00:00

[PR #12] fix: correct IMAGE input type case in example node template #12

New issue

Open

opened 2026-10-31 22:06:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:06:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/cookiecutter-comfy-extension/pull/12
Author: @kaili-yang
Created: 5/12/2026
Status: 🔄 Open

Base: main ← Head: fix/image-input-type-typo

📝 Commits (1)

246cc3f fix: correct IMAGE input type case in example node template

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 {{cookiecutter.project_slug}}/custom-nodes-template/src/{{cookiecutter.project_slug}}/nodes.py (+1 -1)

📄 Description

Summary

Fixes a typo in the generated nodes.py template: "Image" → "IMAGE" on the image input type

Root Cause

The ComfyUI backend (comfy_execution/validation.py) performs exact string comparison when validating node input types at runtime. The frontend (LiteGraphGlobal.ts) normalizes types with .toLowerCase() before checking connections, so the wrong case passes UI validation but fails at execution time.

Effect on users: Load Image → Example Node connects fine in the canvas, but clicking Run throws Return type mismatch between linked nodes — a misleading error for new custom node developers.

Test

before
Screenshot 2026-05-11 at 11 17 28 PM

after
Screenshot 2026-05-12 at 1 00 21 AM

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/cookiecutter-comfy-extension/pull/12 **Author:** [@kaili-yang](https://github.com/kaili-yang) **Created:** 5/12/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/image-input-type-typo` --- ### 📝 Commits (1) - [`246cc3f`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/246cc3f8b99d8daded2e39aaf5e608a0e2656be0) fix: correct IMAGE input type case in example node template ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/src/{{cookiecutter.project_slug}}/nodes.py` (+1 -1) </details> ### 📄 Description ## Summary - Fixes a typo in the generated `nodes.py` template: `"Image"` → `"IMAGE"` on the image input type ## Root Cause The ComfyUI backend (`comfy_execution/validation.py`) performs exact string comparison when validating node input types at runtime. The frontend (`LiteGraphGlobal.ts`) normalizes types with `.toLowerCase()` before checking connections, so the wrong case passes UI validation but fails at execution time. **Effect on users:** Load Image → Example Node connects fine in the canvas, but clicking Run throws `Return type mismatch between linked nodes` — a misleading error for new custom node developers. ## Test before <img width="1054" height="899" alt="Screenshot 2026-05-11 at 11 17 28 PM" src="https://github.com/user-attachments/assets/fba8beb1-f762-4321-8aec-b33b44d72d9c" /> after <img width="1077" height="533" alt="Screenshot 2026-05-12 at 1 00 21 AM" src="https://github.com/user-attachments/assets/b8462be2-1f04-4fe5-9fd6-464e8e7e023a" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 22:06:57 +00:00

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/cookiecutter-comfy-extension#12

No description provided.

Rows
Columns