Comfy-Org/cookiecutter-comfy-extension
1
0
Fork 0
mirror of https://github.com/Comfy-Org/cookiecutter-comfy-extension.git synced 2026-11-04 23:47:39 +00:00
Code Issues 8 Projects Packages Wiki Activity

[GH-ISSUE #6] React template does not initialize #4

New issue
Closed
opened 2026-10-31 22:06:52 +00:00 by bsakaguchi · 6 comments
bsakaguchi commented 2026-10-31 22:06:52 +00:00
Owner
Copy link

Originally created by @mcmalt on GitHub (Aug 2, 2025).
Original GitHub issue: https://github.com/Comfy-Org/cookiecutter-comfy-extension/issues/6

When run by comfy node scaffold and React is selected as a frontend type, the resulting directory does not contain anything from the react extension template.

I'm not particularly familiar with cookiecutter, but I believe I have narrowed down the issue.

github.com/Comfy-Org/cookiecutter-comfy-extension@db6cfd9085/hooks/pre_gen_project.py (L64)

When run, template_source => https://github.com/Comfy-Org/cookiecutter-comfy-extension.git, which does not start with gh, so submodules are never initialized

Removing the condition template_source.startswith("gh:") correctly initializes the submodule.

I have not attempted running cookiecutter directly on the template, so perhaps the behavior is different between comfy node scaffold and cookiecutter gh:comfy-org/cookiecutter-comfy-extension

Edit 2: after looking at the cli source, cookiecutter is run on https://github.com/Comfy-Org/cookiecutter-comfy-extension.git not gh:comfy-org/cookiecutter-comfy-extension, so this may be the cause of the unexpected behavior

Originally created by @mcmalt on GitHub (Aug 2, 2025). Original GitHub issue: https://github.com/Comfy-Org/cookiecutter-comfy-extension/issues/6 When run by `comfy node scaffold` and `React` is selected as a frontend type, the resulting directory does not contain anything from the react extension template. I'm not particularly familiar with cookiecutter, but I believe I have narrowed down the issue. https://github.com/Comfy-Org/cookiecutter-comfy-extension/blob/db6cfd90858df3d272163e2ca511b1305ce63846/hooks/pre_gen_project.py#L64 When run, `template_source => https://github.com/Comfy-Org/cookiecutter-comfy-extension.git`, which does not start with `gh`, so submodules are never initialized Removing the condition `template_source.startswith("gh:")` correctly initializes the submodule. I have not attempted running cookiecutter directly on the template, so perhaps the behavior is different between `comfy node scaffold` and `cookiecutter gh:comfy-org/cookiecutter-comfy-extension` Edit 2: after looking at the cli source, cookiecutter is run on `https://github.com/Comfy-Org/cookiecutter-comfy-extension.git` not `gh:comfy-org/cookiecutter-comfy-extension`, so this may be the cause of the unexpected behavior
bsakaguchi commented 2026-10-31 22:06:53 +00:00
Author
Owner
Copy link

@zcfrank1st commented on GitHub (Aug 5, 2025):

+1

<!-- gh-comment-id:3155135706 --> @zcfrank1st commented on GitHub (Aug 5, 2025): +1
bsakaguchi commented 2026-10-31 22:06:53 +00:00
Author
Owner
Copy link

@christian-byrne commented on GitHub (Aug 6, 2025):

@jtydhr88 Any idea why this happens?

<!-- gh-comment-id:3157019094 --> @christian-byrne commented on GitHub (Aug 6, 2025): @jtydhr88 Any idea why this happens?
bsakaguchi commented 2026-10-31 22:06:53 +00:00
Author
Owner
Copy link

@jtydhr88 commented on GitHub (Aug 9, 2025):

I will take a look at it

<!-- gh-comment-id:3169602282 --> @jtydhr88 commented on GitHub (Aug 9, 2025): I will take a look at it
bsakaguchi commented 2026-10-31 22:06:53 +00:00
Author
Owner
Copy link

@jtydhr88 commented on GitHub (Aug 9, 2025):

thanks @mcmalt feedback, fixed in https://github.com/Comfy-Org/comfy-cli/pull/310

<!-- gh-comment-id:3169640760 --> @jtydhr88 commented on GitHub (Aug 9, 2025): thanks @mcmalt feedback, fixed in https://github.com/Comfy-Org/comfy-cli/pull/310
bsakaguchi commented 2026-10-31 22:06:53 +00:00
Author
Owner
Copy link

@jtydhr88 commented on GitHub (Aug 10, 2025):

at the fixed merged in cli side, I will close it for now, please try later once we release a new version, and please feel free to reopen it if you still have questions

<!-- gh-comment-id:3172277035 --> @jtydhr88 commented on GitHub (Aug 10, 2025): at the fixed merged in cli side, I will close it for now, please try later once we release a new version, and please feel free to reopen it if you still have questions
bsakaguchi commented 2026-10-31 22:06:53 +00:00
Author
Owner
Copy link

@mcmalt commented on GitHub (Aug 10, 2025):

I have manually tested it by mirroring the changes locally to my comfy_cli installation and it works as expected, so when the new version is released I expect it to work correctly. Thanks!

<!-- gh-comment-id:3172800772 --> @mcmalt commented on GitHub (Aug 10, 2025): I have manually tested it by mirroring the changes locally to my comfy_cli installation and it works as expected, so when the new version is released I expect it to work correctly. Thanks!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
luke/fix-issues
vue-template
No results found.
Labels
Clear labels   
bug

   
pull-request
Mirrored from GitHub Pull Request

No labels
bug
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/cookiecutter-comfy-extension#4
No description provided.