[PR #4] [MERGED] add react extension as template #8

New issue

Closed

opened 2026-10-31 22:06:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:06:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/cookiecutter-comfy-extension/pull/4
Author: @jtydhr88
Created: 5/31/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @christian-byrne

Base: main ← Head: add_react_template

📝 Commits (6)

5138dcd add react extension as template
0615fee remove static react files
e2c5ed6 use git submodules
f9fc84b use add submodule
f75189e git update submodule
8ae4514 readme

📊 Changes

26 files changed (+214 additions, -16 deletions)

View changed files

➕ .gitmodules (+3 -0)
📝 README.md (+8 -1)
📝 cookiecutter.json (+10 -2)
📝 hooks/post_gen_project.py (+100 -3)
📝 hooks/pre_gen_project.py (+70 -7)
📝 {{cookiecutter.project_slug}}/common/.editorconfig (+0 -0)
📝 {{cookiecutter.project_slug}}/common/.gitignore (+14 -0)
📝 {{cookiecutter.project_slug}}/common/.pre-commit-config.yaml (+0 -0)
📝 {{cookiecutter.project_slug}}/common/LICENSE (+0 -0)
📝 {{cookiecutter.project_slug}}/common/pyproject.toml (+5 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/.github/ISSUE_TEMPLATE.md (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/build-pipeline.yml (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/publish_node.yml (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/validate.yml (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/.vscode/settings.json (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/MANIFEST.in (+1 -1)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/README.md (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/__init__.py (+2 -2)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/src/{{cookiecutter.project_slug}}/__init__.py (+0 -0)
📝 {{cookiecutter.project_slug}}/custom-nodes-template/src/{{cookiecutter.project_slug}}/nodes.py (+0 -0)

...and 6 more files

📄 Description

add react extension (original is from https://github.com/Comfy-Org/ComfyUI-React-Extension-Template) as template, key changes are:

move the common files (LICENSE, pyproject.toml, etc) into common folder
create a folder named custom-nodes-template to place the original template files
create a folder named react-extension-template to place the react template files and adapt with cookiecutter varibles
add frontend_type = [no, react, js] for each frontend type
need "_copy_without_render": [".tsx", ".ts", "*.yml"] to ignore frontend files during parsing pharse

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/cookiecutter-comfy-extension/pull/4 **Author:** [@jtydhr88](https://github.com/jtydhr88) **Created:** 5/31/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@christian-byrne](https://github.com/christian-byrne) **Base:** `main` ← **Head:** `add_react_template` --- ### 📝 Commits (6) - [`5138dcd`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/5138dcd96f6cc57162a2e50d5a449c2a5aae8bef) add react extension as template - [`0615fee`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/0615feea90795a2a17ba2c345e2399faeaea7296) remove static react files - [`e2c5ed6`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/e2c5ed673dad1d9cd64fdb73ecd94133affdd1ea) use git submodules - [`f9fc84b`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/f9fc84b4dabe7e952cfbdd9ec7c7f5a6273f9666) use add submodule - [`f75189e`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/f75189ea046794d2b96c324a49247ba9858738a7) git update submodule - [`8ae4514`](https://github.com/Comfy-Org/cookiecutter-comfy-extension/commit/8ae45144fd2ca38c9d52e97bfe2c63f79cde73c3) readme ### 📊 Changes **26 files changed** (+214 additions, -16 deletions) <details> <summary>View changed files</summary> ➕ `.gitmodules` (+3 -0) 📝 `README.md` (+8 -1) 📝 `cookiecutter.json` (+10 -2) 📝 `hooks/post_gen_project.py` (+100 -3) 📝 `hooks/pre_gen_project.py` (+70 -7) 📝 `{{cookiecutter.project_slug}}/common/.editorconfig` (+0 -0) 📝 `{{cookiecutter.project_slug}}/common/.gitignore` (+14 -0) 📝 `{{cookiecutter.project_slug}}/common/.pre-commit-config.yaml` (+0 -0) 📝 `{{cookiecutter.project_slug}}/common/LICENSE` (+0 -0) 📝 `{{cookiecutter.project_slug}}/common/pyproject.toml` (+5 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/.github/ISSUE_TEMPLATE.md` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/build-pipeline.yml` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/publish_node.yml` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/validate.yml` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/.vscode/settings.json` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/MANIFEST.in` (+1 -1) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/README.md` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/__init__.py` (+2 -2) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/src/{{cookiecutter.project_slug}}/__init__.py` (+0 -0) 📝 `{{cookiecutter.project_slug}}/custom-nodes-template/src/{{cookiecutter.project_slug}}/nodes.py` (+0 -0) _...and 6 more files_ </details> ### 📄 Description add react extension (original is from https://github.com/Comfy-Org/ComfyUI-React-Extension-Template) as template, key changes are: 1. move the common files (LICENSE, pyproject.toml, etc) into common folder 2. create a folder named custom-nodes-template to place the original template files 3. create a folder named react-extension-template to place the react template files and adapt with cookiecutter varibles 4. add frontend_type = [no, react, js] for each frontend type 5. need "_copy_without_render": ["*.tsx", "*.ts", "*.yml"] to ignore frontend files during parsing pharse --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:06:57 +00:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/cookiecutter-comfy-extension#8

No description provided.

Rows
Columns