[PR #682] [MERGED] [Test] Add comfySettings unit tests #1021

New issue

Closed

opened 2026-10-31 22:18:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/682
Author: @christian-byrne
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/21/2025
Merged by: @huchenlei

Base: main ← Head: unit-test/comfySettings

📝 Commits (1)

95aefb2 extend comfy settings tests

📊 Changes

1 file changed (+56 additions, -4 deletions)

View changed files

📝 tests/unit/comfySettings.test.ts (+56 -4)

📄 Description

Adds test cases to comfySettings tests to include more common branches currently already handled by the class, including:

file read error
null/undefined values
invalid JSON
Also includes cases for common types in comfy settings file: primitive type, reference type, nested object

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/682 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unit-test/comfySettings` --- ### 📝 Commits (1) - [`95aefb2`](https://github.com/Comfy-Org/desktop/commit/95aefb21145d6b8cdc10d198f0d399047157be17) extend comfy settings tests ### 📊 Changes **1 file changed** (+56 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/comfySettings.test.ts` (+56 -4) </details> ### 📄 Description Adds test cases to comfySettings tests to include more common branches currently already handled by the class, including: - file read error - null/undefined values - invalid JSON - Also includes cases for common types in comfy settings file: primitive type, reference type, nested object ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-682-Test-Add-comfySettings-unit-tests-1826d73d365081249b1dd12555257cd1) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:51 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1021

No description provided.

Rows
Columns