[PR #203] [MERGED] Build types for ElectronAPI #682

New issue

Closed

opened 2026-10-31 22:15:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/203
Author: @huchenlei
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @huchenlei

Base: main ← Head: type_lib

📝 Commits (7)

5bf18f4 Add vite-dts
82c2df9 Build types for ElectronAPI
26fcae7 prefix @comfyorg on package name
30072f5 Add publish config
3ffb093 Regen lock
f629233 Add prepare types script
d56bd7c nit

📊 Changes

5 files changed (+677 additions, -66 deletions)

View changed files

📝 package.json (+5 -3)
➕ scripts/prepareTypes.js (+45 -0)
➕ src/main_types.ts (+9 -0)
➕ vite.types.config.ts (+22 -0)
📝 yarn.lock (+596 -63)

📄 Description

We should publish electronAPI types as a library on npm for usage in the frontend repo. Package is published on https://www.npmjs.com/package/@comfyorg/comfyui-electron-types

TODO: Setup auto publish GH action on each release.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/203 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/7/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `type_lib` --- ### 📝 Commits (7) - [`5bf18f4`](https://github.com/Comfy-Org/desktop/commit/5bf18f45d5757cd727debcc63b21da78df02d81b) Add vite-dts - [`82c2df9`](https://github.com/Comfy-Org/desktop/commit/82c2df969f545d9528b46bd062ae9f720928a9f2) Build types for ElectronAPI - [`26fcae7`](https://github.com/Comfy-Org/desktop/commit/26fcae76973da517defa48cfd93b14616fd6936c) prefix @comfyorg on package name - [`30072f5`](https://github.com/Comfy-Org/desktop/commit/30072f5cf1c411175a97516e63f499ebd576b123) Add publish config - [`3ffb093`](https://github.com/Comfy-Org/desktop/commit/3ffb093f4f32eeb6213857654793882e8a3f767e) Regen lock - [`f629233`](https://github.com/Comfy-Org/desktop/commit/f62923348e872363ba090755571acb48f4f21d1f) Add prepare types script - [`d56bd7c`](https://github.com/Comfy-Org/desktop/commit/d56bd7c722d9a9c329c939ede9865387d97277f9) nit ### 📊 Changes **5 files changed** (+677 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+5 -3) ➕ `scripts/prepareTypes.js` (+45 -0) ➕ `src/main_types.ts` (+9 -0) ➕ `vite.types.config.ts` (+22 -0) 📝 `yarn.lock` (+596 -63) </details> ### 📄 Description We should publish electronAPI types as a library on npm for usage in the frontend repo. Package is published on https://www.npmjs.com/package/@comfyorg/comfyui-electron-types TODO: Setup auto publish GH action on each release. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:57 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:51 +00:00

[PR #682] [MERGED] [Test] Add comfySettings unit tests #1021

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#682

No description provided.

Rows
Columns