[PR #695] [MERGED] Fix floating promises #1026

New issue

Closed

opened 2026-10-31 22:18:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/695
Author: @christian-byrne
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @huchenlei

Base: main ← Head: floating-promises

📝 Commits (9)

d6c5ff3 fix floating promises
6e6975e revert suppression of potential unhandled reject
0d2b6f7 Revert promise rewrap
09ae029 revert suppression of potential unhandled reject
a7cbcc7 catch unhandled reject in about menu click cb
84d6df4 revert async, catch reject
0ee5a4c replace IIFE with catch
67043a0 add comment deleted inadvertently
a185882 Revert off-topic changes

📊 Changes

2 files changed (+16 additions, -10 deletions)

View changed files

📝 src/main-process/appWindow.ts (+13 -9)
📝 src/main-process/comfyDesktopApp.ts (+3 -1)

📄 Description

This PR fixes some floating promises by catching unhandled rejections.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/695 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `floating-promises` --- ### 📝 Commits (9) - [`d6c5ff3`](https://github.com/Comfy-Org/desktop/commit/d6c5ff32df7a32385c0937f8afd74834ca82036f) fix floating promises - [`6e6975e`](https://github.com/Comfy-Org/desktop/commit/6e6975e3746cf11729f77577fa333e7b439189b7) revert suppression of potential unhandled reject - [`0d2b6f7`](https://github.com/Comfy-Org/desktop/commit/0d2b6f7bb326e8dc00c8844a80b4d421df29808a) Revert promise rewrap - [`09ae029`](https://github.com/Comfy-Org/desktop/commit/09ae029dc50bf9c0a258de93975e785c882998cf) revert suppression of potential unhandled reject - [`a7cbcc7`](https://github.com/Comfy-Org/desktop/commit/a7cbcc7f7de5f0207a0ad34cfed56ffb74e73ddd) catch unhandled reject in about menu click cb - [`84d6df4`](https://github.com/Comfy-Org/desktop/commit/84d6df44523f71c92cc6c25b8bb15dca779afc65) revert async, catch reject - [`0ee5a4c`](https://github.com/Comfy-Org/desktop/commit/0ee5a4cae5c79f59f588001892f58fa72aa8784c) replace IIFE with catch - [`67043a0`](https://github.com/Comfy-Org/desktop/commit/67043a0475973f6008af1bfcd13c04465be2f12f) add comment deleted inadvertently - [`a185882`](https://github.com/Comfy-Org/desktop/commit/a185882b8cb50741aa3778c3b287dcbcffe1594c) Revert off-topic changes ### 📊 Changes **2 files changed** (+16 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+13 -9) 📝 `src/main-process/comfyDesktopApp.ts` (+3 -1) </details> ### 📄 Description This PR fixes some floating promises by catching unhandled rejections. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-695-Fix-floating-promises-1836d73d365081dc8495ca778fca5e1a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:54 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1026

No description provided.

Rows
Columns