[PR #217] [MERGED] Fix type library configuration #695

New issue

Closed

opened 2026-10-31 22:16:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/217
Author: @huchenlei
Created: 11/10/2024
Status: ✅ Merged
Merged: 11/10/2024
Merged by: @huchenlei

Base: main ← Head: fix_type_lib

📝 Commits (2)

2aee460 Fix main_types import/export
13f6978 Update typelib package

📊 Changes

2 files changed (+6 additions, -11 deletions)

View changed files

📝 scripts/prepareTypes.js (+3 -6)
📝 src/main_types.ts (+3 -5)

📄 Description

Previously only the index.d.ts file was included in the package, which was not enough for the caller to get the actual enum definition and constant definitions. This PR fixes this issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/217 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/10/2024 **Status:** ✅ Merged **Merged:** 11/10/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_type_lib` --- ### 📝 Commits (2) - [`2aee460`](https://github.com/Comfy-Org/desktop/commit/2aee460d74a6dfe3dcba637c3b36ea2c520973fe) Fix main_types import/export - [`13f6978`](https://github.com/Comfy-Org/desktop/commit/13f6978e38f238f858642f993a999256952acc1e) Update typelib package ### 📊 Changes **2 files changed** (+6 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `scripts/prepareTypes.js` (+3 -6) 📝 `src/main_types.ts` (+3 -5) </details> ### 📄 Description Previously only the index.d.ts file was included in the package, which was not enough for the caller to get the actual enum definition and constant definitions. This PR fixes this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:04 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:54 +00:00

[PR #695] [MERGED] Fix floating promises #1026

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#695

No description provided.

Rows
Columns