[PR #711] [MERGED] Add electronAPI.Network.canAccessUrl #1038

New issue

Closed

opened 2026-10-31 22:18:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/711
Author: @huchenlei
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @huchenlei

Base: main ← Head: access_url

📝 Commits (1)

6de6adb Add electronAPI.Network.canAccessUrl

📊 Changes

5 files changed (+52 additions, -0 deletions)

View changed files

📝 src/constants.ts (+1 -0)
➕ src/handlers/networkHandlers.ts (+15 -0)
📝 src/main.ts (+2 -0)
📝 src/preload.ts (+5 -0)
📝 src/utils.ts (+29 -0)

📄 Description

The frontend won't be able to access remote mirrors because of CoRS policy. This PR exposes a electronAPI to check accessibility of url.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/711 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `access_url` --- ### 📝 Commits (1) - [`6de6adb`](https://github.com/Comfy-Org/desktop/commit/6de6adb56dc8ffbca59b111e5b48a616c6dc45ac) Add electronAPI.Network.canAccessUrl ### 📊 Changes **5 files changed** (+52 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+1 -0) ➕ `src/handlers/networkHandlers.ts` (+15 -0) 📝 `src/main.ts` (+2 -0) 📝 `src/preload.ts` (+5 -0) 📝 `src/utils.ts` (+29 -0) </details> ### 📄 Description The frontend won't be able to access remote mirrors because of CoRS policy. This PR exposes a electronAPI to check accessibility of url. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-711-Add-electronAPI-Network-canAccessUrl-1846d73d36508130a6cacfcf5e1d33bb) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:59 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1038

No description provided.

Rows
Columns