[PR #235] [MERGED] Implement install APIs #711

New issue

Closed

opened 2026-10-31 22:16:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/235
Author: @huchenlei
Created: 11/13/2024
Status: ✅ Merged
Merged: 11/13/2024
Merged by: @huchenlei

Base: main ← Head: impl_install

📝 Commits (10+)

d179175 Implement getSystemPaths
2fcb4e6 nit
3d07535 Remove SHOW_SELECT_DIRECTORY
ea5cf7e Remove FIRST_TIME_SETUP_COMPLETE
65390e2 Validate install path
7c2fd4c Implement migration items
186770a Implement VALIDATE_COMFYUI_SOURCE
451fd26 Implement SHOW_DIRECTORY_PICKER
3d56d28 Implement handle install
0e37ba5 Move python install path

📊 Changes

14 files changed (+190 additions, -537 deletions)

View changed files

📝 .env_example (+6 -0)
📝 scripts/launchdev.js (+1 -5)
📝 src/constants.ts (+31 -5)
📝 src/handlers/appInfoHandlers.ts (+0 -5)
📝 src/handlers/pathHandlers.ts (+76 -1)
➕ src/install/index.ts (+0 -0)
📝 src/main-process/appWindow.ts (+10 -6)
📝 src/main.ts (+44 -45)
📝 src/preload.ts (+19 -56)
📝 src/renderer/index.tsx (+2 -80)
➖ src/renderer/screens/AnimatedLogDisplay.tsx (+0 -49)
➖ src/renderer/screens/FirstTimeSetup.tsx (+0 -187)
➖ src/renderer/screens/ProgressOverlay.tsx (+0 -92)
📝 tests/unit/handlers/appinfoHandlers.test.ts (+1 -6)

📄 Description

This PR:

Remove legacy React frontend for onboarding screen
Use ComfyUI_frontend's onboarding logic by directly loading index.html#welcome from ComfyUI_frontend compiled dist
Implemented necessary APIs used by ComfyUI_frontend onboarding wizard

Follow-up tasks:

Completely remove the react dependency
Implement migration logic (Copy over existing user files and link existing model dirs)

Note:

Set DEV_SERVER_URL in .env to load from external dev server for onboarding page.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/235 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `impl_install` --- ### 📝 Commits (10+) - [`d179175`](https://github.com/Comfy-Org/desktop/commit/d179175d5ad260e0a6e8b4f443d53ad31cbabe46) Implement getSystemPaths - [`2fcb4e6`](https://github.com/Comfy-Org/desktop/commit/2fcb4e6cf695f32b82480597423130b24651bc97) nit - [`3d07535`](https://github.com/Comfy-Org/desktop/commit/3d07535855cb0ff49a5072b30c68e408efd8adae) Remove SHOW_SELECT_DIRECTORY - [`ea5cf7e`](https://github.com/Comfy-Org/desktop/commit/ea5cf7e36a600bfd3dbdcb52cf7095f165058ba4) Remove FIRST_TIME_SETUP_COMPLETE - [`65390e2`](https://github.com/Comfy-Org/desktop/commit/65390e210a5f2ab7bb94de2d695d8d1494fac12a) Validate install path - [`7c2fd4c`](https://github.com/Comfy-Org/desktop/commit/7c2fd4ca1fb4e5af3a9ee6d21f29eef8c377cd47) Implement migration items - [`186770a`](https://github.com/Comfy-Org/desktop/commit/186770a87e6e89ebfa534d9219dedeeb3735a5b1) Implement VALIDATE_COMFYUI_SOURCE - [`451fd26`](https://github.com/Comfy-Org/desktop/commit/451fd26cb9346389ff261460bb5c2eed6dbc61de) Implement SHOW_DIRECTORY_PICKER - [`3d56d28`](https://github.com/Comfy-Org/desktop/commit/3d56d2814311a3777aba53620315d4cbc3858906) Implement handle install - [`0e37ba5`](https://github.com/Comfy-Org/desktop/commit/0e37ba5e3a3837614c21a23b50f51b9014e48434) Move python install path ### 📊 Changes **14 files changed** (+190 additions, -537 deletions) <details> <summary>View changed files</summary> 📝 `.env_example` (+6 -0) 📝 `scripts/launchdev.js` (+1 -5) 📝 `src/constants.ts` (+31 -5) 📝 `src/handlers/appInfoHandlers.ts` (+0 -5) 📝 `src/handlers/pathHandlers.ts` (+76 -1) ➕ `src/install/index.ts` (+0 -0) 📝 `src/main-process/appWindow.ts` (+10 -6) 📝 `src/main.ts` (+44 -45) 📝 `src/preload.ts` (+19 -56) 📝 `src/renderer/index.tsx` (+2 -80) ➖ `src/renderer/screens/AnimatedLogDisplay.tsx` (+0 -49) ➖ `src/renderer/screens/FirstTimeSetup.tsx` (+0 -187) ➖ `src/renderer/screens/ProgressOverlay.tsx` (+0 -92) 📝 `tests/unit/handlers/appinfoHandlers.test.ts` (+1 -6) </details> ### 📄 Description ## This PR: - Remove legacy React frontend for onboarding screen - Use ComfyUI_frontend's onboarding logic by directly loading `index.html#welcome` from ComfyUI_frontend compiled dist - Implemented necessary APIs used by ComfyUI_frontend onboarding wizard ## Follow-up tasks: - Completely remove the react dependency - Implement migration logic (Copy over existing user files and link existing model dirs) ## Note: Set `DEV_SERVER_URL` in `.env` to load from external dev server for onboarding page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:59 +00:00

[PR #711] [MERGED] Add electronAPI.Network.canAccessUrl #1038

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#711

No description provided.

Rows
Columns