[PR #737] [MERGED] Remove virtual environment creation from server start #1060

New issue

Closed

opened 2026-10-31 22:19:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/737
Author: @webfiltered
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/25/2025
Merged by: @huchenlei

Base: main ← Head: create-venv-during-installation

📝 Commits (1)

017c014 Move virtual env create logic into installer

📊 Changes

2 files changed (+59 additions, -53 deletions)

View changed files

📝 src/install/installationManager.ts (+53 -4)
📝 src/main-process/comfyDesktopApp.ts (+6 -49)

📄 Description

Current

Virtual environment creation is called on each app start, just before server init
Immediately returns if directory is present
Made redundant by app maintenance / startup validation

Proposed

Moves venv creation from app startup to installation logic
Minimal PR - moves code as-is
Clean up / refactoring can be handled separtately

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/737 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/25/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `create-venv-during-installation` --- ### 📝 Commits (1) - [`017c014`](https://github.com/Comfy-Org/desktop/commit/017c014bea7e97db230b86d8651fb14cc6c509aa) Move virtual env create logic into installer ### 📊 Changes **2 files changed** (+59 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+53 -4) 📝 `src/main-process/comfyDesktopApp.ts` (+6 -49) </details> ### 📄 Description #### Current - Virtual environment creation is called on each app start, just before server init - Immediately returns if directory is present - Made redundant by app maintenance / startup validation #### Proposed - Moves venv creation from app startup to installation logic - Minimal PR - moves code as-is - Clean up / refactoring can be handled separtately ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-737-Remove-virtual-environment-creation-from-server-start-1856d73d365081749fc6f3381dd56ebe) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:20 +00:00

[PR #1060] [MERGED] Check if directory is empty before installation warning. #1312

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1060

No description provided.

Rows
Columns