[PR #1060] [MERGED] Check if directory is empty before installation warning. #1312

New issue

Closed

opened 2026-10-31 22:21:20 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1060
Author: @robinjhuang
Created: 3/15/2025
Status: ✅ Merged
Merged: 3/16/2025
Merged by: @robinjhuang

Base: main ← Head: rh-validate2

📝 Commits (2)

6bfa92a Only return "exists" when the directory is not empty.
0aba74e Add tests.

📊 Changes

2 files changed (+27 additions, -4 deletions)

View changed files

📝 src/handlers/pathHandlers.ts (+7 -2)
📝 tests/unit/handlers/pathHandler.test.ts (+20 -2)

📄 Description

Only return "exists" when the directory is not empty.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1060 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 3/16/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-validate2` --- ### 📝 Commits (2) - [`6bfa92a`](https://github.com/Comfy-Org/desktop/commit/6bfa92a86d4d0e685676a4558543e878a8bb41cc) Only return "exists" when the directory is not empty. - [`0aba74e`](https://github.com/Comfy-Org/desktop/commit/0aba74eca48d6c1ac04d7f793fa00c0f52d85f19) Add tests. ### 📊 Changes **2 files changed** (+27 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/pathHandlers.ts` (+7 -2) 📝 `tests/unit/handlers/pathHandler.test.ts` (+20 -2) </details> ### 📄 Description Only return "exists" when the directory is not empty. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1060-Check-if-directory-is-empty-before-installation-warning-1b76d73d365081bc8b2bef6d3bdc3cc7) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:20 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1312

No description provided.

Rows
Columns