[PR #751] [MERGED] Fix pypi mirror usage in virtualEnvironment.ts #1068

New issue

Closed

opened 2026-10-31 22:19:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/751
Author: @huchenlei
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @huchenlei

Base: main ← Head: fix_pypi

📝 Commits (5)

dd9b9bf Refactor pip usage
4c397d8 Fix pypi mirror usage
a5efd4a Revert unrelated changes
12a04bb format
cae8fa9 Update virtualEnvironment.ts

📊 Changes

1 file changed (+31 additions, -9 deletions)

View changed files

📝 src/virtualEnvironment.ts (+31 -9)

📄 Description

Ref: https://github.com/Comfy-Org/ComfyUI_frontend/pull/2333#discussion_r1929091492

UV does not accept Pypi env variable. The Pypi mirror should be used as index-url when invoking pip command.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/751 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_pypi` --- ### 📝 Commits (5) - [`dd9b9bf`](https://github.com/Comfy-Org/desktop/commit/dd9b9bf078cf4a6241a5d800519e1d0eaf6d977f) Refactor pip usage - [`4c397d8`](https://github.com/Comfy-Org/desktop/commit/4c397d8411a3ef199fe1190ef196b26630c9fdfc) Fix pypi mirror usage - [`a5efd4a`](https://github.com/Comfy-Org/desktop/commit/a5efd4a361557415a1c8bd650c7cfb82c4e7684b) Revert unrelated changes - [`12a04bb`](https://github.com/Comfy-Org/desktop/commit/12a04bbb130400af1d4dd5c35b98381faa91c711) format - [`cae8fa9`](https://github.com/Comfy-Org/desktop/commit/cae8fa921931c13a13082ba5abf7b7775a05cdc6) Update virtualEnvironment.ts ### 📊 Changes **1 file changed** (+31 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+31 -9) </details> ### 📄 Description Ref: https://github.com/Comfy-Org/ComfyUI_frontend/pull/2333#discussion_r1929091492 UV does not accept Pypi env variable. The Pypi mirror should be used as `index-url` when invoking `pip` command. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-751-Fix-pypi-mirror-usage-in-virtualEnvironment-ts-1896d73d365081cca547f12ef497f8a4) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:14 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1068

No description provided.

Rows
Columns