[PR #278] [MERGED] Replace custom wait logic with wait-on package #751

New issue

Closed

opened 2026-10-31 22:16:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/278
Author: @huchenlei
Created: 11/17/2024
Status: ✅ Merged
Merged: 11/17/2024
Merged by: @huchenlei

Base: main ← Head: wait_ready

📝 Commits (1)

cbfac36 Replace custom wait logic with wait-on package

📊 Changes

3 files changed (+119 additions, -50 deletions)

View changed files

📝 package.json (+2 -0)
📝 src/main.ts (+22 -49)
📝 yarn.lock (+95 -1)

📄 Description

This PR replaces custom waiting logic for ComfyUI server with wait-on package. This greatly simplifes the code.

Ref: wait-on package: https://github.com/jeffbski/wait-on#readme

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/278 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/17/2024 **Status:** ✅ Merged **Merged:** 11/17/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `wait_ready` --- ### 📝 Commits (1) - [`cbfac36`](https://github.com/Comfy-Org/desktop/commit/cbfac361fc3549b5336337a025c8892eca62e67c) Replace custom wait logic with wait-on package ### 📊 Changes **3 files changed** (+119 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -0) 📝 `src/main.ts` (+22 -49) 📝 `yarn.lock` (+95 -1) </details> ### 📄 Description This PR replaces custom waiting logic for ComfyUI server with `wait-on` package. This greatly simplifes the code. Ref: wait-on package: https://github.com/jeffbski/wait-on#readme --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:19:14 +00:00

[PR #751] [MERGED] Fix pypi mirror usage in virtualEnvironment.ts #1068

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#751

No description provided.

Rows
Columns