[PR #755] [MERGED] Fix install packages loop #1072

New issue

Closed

opened 2026-10-31 22:19:16 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/755
Author: @webfiltered
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @webfiltered

Base: main ← Head: fix-install-packages-loop

📝 Commits (2)

eaf64bb Remove redundant code
b3f9dff Fix maintenance task endless loop

📊 Changes

1 file changed (+1 additions, -7 deletions)

View changed files

📝 src/virtualEnvironment.ts (+1 -7)

📄 Description

Current

If user runs the app with the VIRTUAL_ENV var set, the maintenance task to check installed python packages will use that venv.

Proposed

Use explicit env var to override user env vars.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/755 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-install-packages-loop` --- ### 📝 Commits (2) - [`eaf64bb`](https://github.com/Comfy-Org/desktop/commit/eaf64bb69af846344a915e280423ac32c3e4ae13) Remove redundant code - [`b3f9dff`](https://github.com/Comfy-Org/desktop/commit/b3f9dffc84b7c5f7dde9b062a580c872a910b119) Fix maintenance task endless loop ### 📊 Changes **1 file changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+1 -7) </details> ### 📄 Description #### Current If user runs the app with the VIRTUAL_ENV var set, the maintenance task to check installed python packages will use that venv. #### Proposed Use explicit env var to override user env vars. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-755-Fix-install-packages-loop-1896d73d365081669092fa9e826d499c) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:16 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:24 +00:00

[PR #1072] [MERGED] Remove core branch. #1320

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1072

No description provided.

Rows
Columns