[PR #284] [CLOSED] Sanity check if the double yarn install bug happens again #755

Closed
opened 2026-10-31 22:16:37 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/284
Author: @KenCorma
Created: 11/18/2024
Status: ❌ Closed

Base: main ← Head: dev-ken


📝 Commits (1)

  • fcc6851 If comfyUI exists then throw error.

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 scripts/todesktop/postInstall.js (+5 -1)

📄 Description

There was a bug in ToDesktop that would cause the second yarn install to not have the correct "first run" flag. Although that is fixed this will catch any other scenario that would cause comfyUI to try to install again.

┆Issue is synchronized with this Notion page by Unito


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/284 **Author:** [@KenCorma](https://github.com/KenCorma) **Created:** 11/18/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev-ken` --- ### 📝 Commits (1) - [`fcc6851`](https://github.com/Comfy-Org/desktop/commit/fcc685111da02620db477d153431556e56a81f4c) If comfyUI exists then throw error. ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `scripts/todesktop/postInstall.js` (+5 -1) </details> ### 📄 Description There was a bug in ToDesktop that would cause the second yarn install to not have the correct "first run" flag. Although that is fixed this will catch any other scenario that would cause comfyUI to try to install again. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-284-Sanity-check-if-the-double-yarn-install-bug-happens-again-15f6d73d365081bc9734dab9584d932d) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:16:37 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#755
No description provided.