mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[PR #284] [CLOSED] Sanity check if the double yarn install bug happens again #755
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#755
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/desktop/pull/284
Author: @KenCorma
Created: 11/18/2024
Status: ❌ Closed
Base:
main← Head:dev-ken📝 Commits (1)
fcc6851If comfyUI exists then throw error.📊 Changes
1 file changed (+5 additions, -1 deletions)
View changed files
📝
scripts/todesktop/postInstall.js(+5 -1)📄 Description
There was a bug in ToDesktop that would cause the second yarn install to not have the correct "first run" flag. Although that is fixed this will catch any other scenario that would cause comfyUI to try to install again.
┆Issue is synchronized with this Notion page by Unito
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.