[PR #760] [MERGED] Fix fresh install crash #1077

New issue

Closed

opened 2026-10-31 22:19:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/760
Author: @webfiltered
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @webfiltered

Base: main ← Head: fix-fresh-install-crash

📝 Commits (3)

178a28f Add ElectronError to reduce error boilerplate
b6647ad Guard against Electron inter-process race
76df5a1 Ensure pages are not reloaded unnecessarily

📊 Changes

3 files changed (+75 additions, -2 deletions)

View changed files

➕ src/infrastructure/electronError.ts (+57 -0)
📝 src/install/installationManager.ts (+4 -1)
📝 src/main-process/appWindow.ts (+14 -1)

📄 Description

Current

Fresh install shows error and exits:

Awaiting Electron's window.webContents.loadFile does not actually guarantee Chromium has finished loading and will accept another navigation request.
This error is not preventing page load or having any measurable effect.

Proposed

Add current URL check before loading page
Add error handling to ignore this specific error
- This specific error should not occur for any normal frontend access

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/760 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-fresh-install-crash` --- ### 📝 Commits (3) - [`178a28f`](https://github.com/Comfy-Org/desktop/commit/178a28fdfb72c098af7676bc3a05a34e4a21bdad) Add ElectronError to reduce error boilerplate - [`b6647ad`](https://github.com/Comfy-Org/desktop/commit/b6647ad81382401b232bb03c3c1650a7a9adda21) Guard against Electron inter-process race - [`76df5a1`](https://github.com/Comfy-Org/desktop/commit/76df5a1b2f6433861bdd98aee8cc005f44466392) Ensure pages are not reloaded unnecessarily ### 📊 Changes **3 files changed** (+75 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `src/infrastructure/electronError.ts` (+57 -0) 📝 `src/install/installationManager.ts` (+4 -1) 📝 `src/main-process/appWindow.ts` (+14 -1) </details> ### 📄 Description #### Current Fresh install shows error and exits: ![image](https://github.com/user-attachments/assets/46dd9a8a-0c27-47a4-bfc7-425d619df1d5) - Awaiting Electron's `window.webContents.loadFile` does not actually guarantee Chromium has finished loading and will accept another navigation request. - This error is not preventing page load or having any measurable effect. #### Proposed - Add current URL check before loading page - Add error handling to ignore this specific error - This specific error should not occur for any normal frontend access ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-760-Fix-fresh-install-crash-18a6d73d3650814285a9ec16105a5beb) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:18 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:28 +00:00

[PR #1088] [CLOSED] Add support for Blackwell GPUs (PyTorch compiled with CUDA 12.8) #1328

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1077

No description provided.

Rows
Columns