[PR #762] [MERGED] [Cleanup] Installation manager refactor / clean up #1078

New issue

Closed

opened 2026-10-31 22:19:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/762
Author: @webfiltered
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @webfiltered

Base: main ← Head: refactor-install-mgr

📝 Commits (6)

62feab5 nit - Remove redundant code
a426286 nit
d51a491 Save config earlier during installation
c8dfef5 nit - Doc
f7df07a Remove repeated status update
1edffec Ensure page is loaded earlier

📊 Changes

1 file changed (+19 additions, -11 deletions)

View changed files

📝 src/install/installationManager.ts (+19 -11)

📄 Description

Moves page load earlier
Saves settings to config.json earlier
nits

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/762 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `refactor-install-mgr` --- ### 📝 Commits (6) - [`62feab5`](https://github.com/Comfy-Org/desktop/commit/62feab5fac2f85dbca25595f21e2cacf5fa091c3) nit - Remove redundant code - [`a426286`](https://github.com/Comfy-Org/desktop/commit/a42628672e0d45dee5c47e0cea9aae97733e0adf) nit - [`d51a491`](https://github.com/Comfy-Org/desktop/commit/d51a4915fef188d69acebbd181c29dc48d4c94d0) Save config earlier during installation - [`c8dfef5`](https://github.com/Comfy-Org/desktop/commit/c8dfef52a7dc58f087785bf1125536f0480853d7) nit - Doc - [`f7df07a`](https://github.com/Comfy-Org/desktop/commit/f7df07a3f4e58f202a953e5ebde62e9136c95e15) Remove repeated status update - [`1edffec`](https://github.com/Comfy-Org/desktop/commit/1edffec4429d0c187ddb254fefc236b2ff450adb) Ensure page is loaded earlier ### 📊 Changes **1 file changed** (+19 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+19 -11) </details> ### 📄 Description - Moves page load earlier - Saves settings to config.json earlier - nits ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-762-Cleanup-Installation-manager-refactor-clean-up-18a6d73d365081a5af56ef272f1c7284) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:18 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1078

No description provided.

Rows
Columns