[PR #292] [MERGED] Revert "Revert "Terminal commands"" #762

New issue

Closed

opened 2026-10-31 22:16:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/292
Author: @robinjhuang
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/20/2024
Merged by: @robinjhuang

Base: main ← Head: revert-291-revert-237-terminal-commands

📝 Commits (4)

5ccf7bf Revert "Revert "Terminal commands (#237)" (#291)"
8a418b0 Add electron-builder version to 25+.
0dd3067 Add node-abi
fa802d6 Remove node-abi.

📊 Changes

10 files changed (+216 additions, -6 deletions)

View changed files

📝 README.md (+22 -0)
📝 builder-debug.config.ts (+1 -0)
📝 package.json (+3 -1)
📝 src/constants.ts (+4 -0)
📝 src/main-process/comfyDesktopApp.ts (+18 -1)
📝 src/main.ts (+0 -2)
📝 src/preload.ts (+34 -0)
➕ src/terminal.ts (+67 -0)
📝 todesktop.json (+1 -0)
📝 yarn.lock (+66 -2)

📄 Description

Reverts Comfy-Org/electron#291

Additional changes:

Upgrades frontend to 1.4.2
Adds appBuilderLibVersion to 25.1.8 because 25+ uses @electron/rebuild to rebuild native dependencies and not node-pty
https://github.com/electron-userland/electron-builder/issues/8024#issuecomment-1926693800

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/292 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `revert-291-revert-237-terminal-commands` --- ### 📝 Commits (4) - [`5ccf7bf`](https://github.com/Comfy-Org/desktop/commit/5ccf7bfbbd0cd422345c79e68a7548469a4563ae) Revert "Revert "Terminal commands (#237)" (#291)" - [`8a418b0`](https://github.com/Comfy-Org/desktop/commit/8a418b0fe7d1f8cedf4482c954585bc1d1b8a89b) Add electron-builder version to 25+. - [`0dd3067`](https://github.com/Comfy-Org/desktop/commit/0dd3067ecd74d040473793e284fa5e0ee106f78f) Add node-abi - [`fa802d6`](https://github.com/Comfy-Org/desktop/commit/fa802d6f2ec523db40a7ed194262ad3a1cb52f96) Remove node-abi. ### 📊 Changes **10 files changed** (+216 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+22 -0) 📝 `builder-debug.config.ts` (+1 -0) 📝 `package.json` (+3 -1) 📝 `src/constants.ts` (+4 -0) 📝 `src/main-process/comfyDesktopApp.ts` (+18 -1) 📝 `src/main.ts` (+0 -2) 📝 `src/preload.ts` (+34 -0) ➕ `src/terminal.ts` (+67 -0) 📝 `todesktop.json` (+1 -0) 📝 `yarn.lock` (+66 -2) </details> ### 📄 Description Reverts Comfy-Org/electron#291 Additional changes: - Upgrades frontend to 1.4.2 - Adds appBuilderLibVersion to 25.1.8 because 25+ uses @electron/rebuild to rebuild native dependencies and not node-pty https://github.com/electron-userland/electron-builder/issues/8024#issuecomment-1926693800 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:40 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:19:18 +00:00

[PR #762] [MERGED] [Cleanup] Installation manager refactor / clean up #1078

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#762

No description provided.

Rows
Columns