[PR #802] [MERGED] [Refactor] Simplify app start logic - simplify config load #1113

New issue

Closed

opened 2026-10-31 22:19:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/802
Author: @webfiltered
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/3/2025
Merged by: @webfiltered

Base: main ← Head: clean-main-v

📝 Commits (5)

95f4eca Add fatal error handler with 'never' control type
42e836f [Refactor] Move config load out of DesktopApp
7facb59 nit - Rename
e6263d6 nit - Doc
7b9c714 Update test expectations

📊 Changes

4 files changed (+50 additions, -23 deletions)

View changed files

📝 src/desktopApp.ts (+35 -16)
📝 src/main.ts (+13 -2)
📝 src/store/desktopConfig.ts (+0 -1)
📝 tests/unit/store/desktopConfig.test.ts (+2 -4)

📄 Description

Adds fatal error interface to reduce boilerplate try/catch handling
Simplifies config load code

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/802 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/3/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `clean-main-v` --- ### 📝 Commits (5) - [`95f4eca`](https://github.com/Comfy-Org/desktop/commit/95f4eca216be989ce57c8c9364bd10fdff2ce2f7) Add fatal error handler with 'never' control type - [`42e836f`](https://github.com/Comfy-Org/desktop/commit/42e836fe0574154f6ae8b41881f2974d73aecad9) [Refactor] Move config load out of DesktopApp - [`7facb59`](https://github.com/Comfy-Org/desktop/commit/7facb5975815fc7d3fbab43f60ba37a7425f0dfa) nit - Rename - [`e6263d6`](https://github.com/Comfy-Org/desktop/commit/e6263d6de0db728f7b14498a06d34e76854216ac) nit - Doc - [`7b9c714`](https://github.com/Comfy-Org/desktop/commit/7b9c71433ae9a076044566762e2b190b737d4b7d) Update test expectations ### 📊 Changes **4 files changed** (+50 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/desktopApp.ts` (+35 -16) 📝 `src/main.ts` (+13 -2) 📝 `src/store/desktopConfig.ts` (+0 -1) 📝 `tests/unit/store/desktopConfig.test.ts` (+2 -4) </details> ### 📄 Description - Adds fatal error interface to reduce boilerplate try/catch handling - Simplifies config load code ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-802-Refactor-Simplify-app-start-logic-simplify-config-load-18f6d73d365081118b29f08577d5cbff) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:35 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1113

No description provided.

Rows
Columns