[PR #341] [MERGED] Strict string launch arg value #802

New issue

Closed

opened 2026-10-31 22:17:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/341
Author: @huchenlei
Created: 11/24/2024
Status: ✅ Merged
Merged: 11/24/2024
Merged by: @huchenlei

Base: main ← Head: string_args

📝 Commits (1)

f3c8299 Strict string launch arg value

📊 Changes

4 files changed (+6 additions, -7 deletions)

View changed files

📝 src/config/comfySettings.ts (+1 -1)
📝 src/constants.ts (+1 -1)
📝 src/main-process/comfyServer.ts (+2 -2)
📝 src/main.ts (+2 -3)

📄 Description

Ref: https://github.com/Comfy-Org/ComfyUI_frontend/pull/1669

Now we use strictly all string values as launch arg object values.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/341 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/24/2024 **Status:** ✅ Merged **Merged:** 11/24/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `string_args` --- ### 📝 Commits (1) - [`f3c8299`](https://github.com/Comfy-Org/desktop/commit/f3c829969fd367d7483e05f3acd31e8984ac79bf) Strict string launch arg value ### 📊 Changes **4 files changed** (+6 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfySettings.ts` (+1 -1) 📝 `src/constants.ts` (+1 -1) 📝 `src/main-process/comfyServer.ts` (+2 -2) 📝 `src/main.ts` (+2 -3) </details> ### 📄 Description Ref: https://github.com/Comfy-Org/ComfyUI_frontend/pull/1669 Now we use strictly all string values as launch arg object values. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:04 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:19:35 +00:00

[PR #802] [MERGED] [Refactor] Simplify app start logic - simplify config load #1113

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#802

No description provided.

Rows
Columns