[PR #878] [MERGED] Add structured logging transform (file) #1172

New issue

Closed

opened 2026-10-31 22:20:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/878
Author: @webfiltered
Created: 2/9/2025
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @webfiltered

Base: main ← Head: structured-logging

📝 Commits (3)

29b81e6 Add structured logging transform (file)
a1e9d58 Prefer structured logging over string formatting
2ae74e6 nit - Rename file

📊 Changes

5 files changed (+67 additions, -7 deletions)

View changed files

📝 src/config/comfyConfigManager.ts (+2 -2)
➕ src/infrastructure/structuredLogging.ts (+54 -0)
📝 src/main.ts (+7 -1)
📝 src/services/telemetry.ts (+3 -3)
📝 src/virtualEnvironment.ts (+1 -1)

📄 Description

Implements structured logging specifically for file logging
Uses compact, single-line formatting
Removes manual object stringification

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/878 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/9/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `structured-logging` --- ### 📝 Commits (3) - [`29b81e6`](https://github.com/Comfy-Org/desktop/commit/29b81e60601d7daa155662ac3281887c17800ffe) Add structured logging transform (file) - [`a1e9d58`](https://github.com/Comfy-Org/desktop/commit/a1e9d5813d17050f11b57efdb17316b7a2cceefd) Prefer structured logging over string formatting - [`2ae74e6`](https://github.com/Comfy-Org/desktop/commit/2ae74e6e8a93f08e8a084c370ce37574ae991d87) nit - Rename file ### 📊 Changes **5 files changed** (+67 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfyConfigManager.ts` (+2 -2) ➕ `src/infrastructure/structuredLogging.ts` (+54 -0) 📝 `src/main.ts` (+7 -1) 📝 `src/services/telemetry.ts` (+3 -3) 📝 `src/virtualEnvironment.ts` (+1 -1) </details> ### 📄 Description - Implements structured logging specifically for file logging - Uses compact, single-line formatting - Removes manual object stringification ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-878-Add-structured-logging-transform-file-1956d73d365081b2bee2ffe95a417e60) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:06 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:58 +00:00

[PR #1172] [MERGED] Change wording of NVIDIA GPU detection error #1386

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1172

No description provided.

Rows
Columns