[PR #1172] [MERGED] Change wording of NVIDIA GPU detection error #1386

New issue

Closed

opened 2026-10-31 22:21:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1172
Author: @benceruleanlu
Created: 5/18/2025
Status: ✅ Merged
Merged: 5/18/2025
Merged by: @webfiltered

Base: main ← Head: bl-no-video-card-nit

📝 Commits (1)

14e1b06 Change wording of nvidia gpu detection error

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/utils.ts (+1 -1)

📄 Description

The error message of "No video card" is slightly misleading, as the res checks specifically for NVIDIA GPUs.

This PR suggests changing this error message slightly to more accurately reflect the check done.

github.com/Comfy-Org/desktop@df5ae706e7/src/utils.ts (L172-L175)

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1172 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 5/18/2025 **Status:** ✅ Merged **Merged:** 5/18/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `bl-no-video-card-nit` --- ### 📝 Commits (1) - [`14e1b06`](https://github.com/Comfy-Org/desktop/commit/14e1b06d163945d2aa6924a314c8eb6178a437b3) Change wording of nvidia gpu detection error ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/utils.ts` (+1 -1) </details> ### 📄 Description The error message of "No video card" is slightly misleading, as the res checks specifically for NVIDIA GPUs. This PR suggests changing this error message slightly to more accurately reflect the check done. https://github.com/Comfy-Org/desktop/blob/df5ae706e7f914a7bb6ccc7ab50a5abebf7170de/src/utils.ts#L172-L175 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1172-Change-wording-of-NVIDIA-GPU-detection-error-1f76d73d365081c69fe5f5cbe22d3c1d) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:58 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1386

No description provided.

Rows
Columns