[PR #890] [MERGED] [Test] Always automock electron-log #1185

New issue

Closed

opened 2026-10-31 22:20:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/890
Author: @webfiltered
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @webfiltered

Base: main ← Head: shhhh

📝 Commits (2)

35b4e36 [Test] Always automock electron-log
cd5b174 Remove dynamic imports - not required

📊 Changes

12 files changed (+10 additions, -69 deletions)

View changed files

📝 tests/unit/config/comfyConfigManager.test.ts (+3 -13)
📝 tests/unit/config/comfyServerConfig.test.ts (+2 -10)
📝 tests/unit/config/comfySettings.test.ts (+0 -7)
📝 tests/unit/desktopApp.test.ts (+0 -7)
📝 tests/unit/handlers/AppHandlers.test.ts (+0 -6)
📝 tests/unit/install/installWizard.test.ts (+0 -1)
📝 tests/unit/install/installationManager.test.ts (+0 -1)
📝 tests/unit/main-process/appWindow.test.ts (+0 -7)
📝 tests/unit/main-process/comfyDesktopApp.test.ts (+0 -8)
➕ tests/unit/setup.ts (+3 -0)
📝 tests/unit/store/desktopConfig.test.ts (+0 -8)
📝 vite.config.ts (+2 -1)

📄 Description

Adds global setup file for vitest
Automocks electron-log/main in all unit tests
Removes all manual mocking of that module

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/890 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `shhhh` --- ### 📝 Commits (2) - [`35b4e36`](https://github.com/Comfy-Org/desktop/commit/35b4e36381e79a507b7b13365e06966f535b0266) [Test] Always automock electron-log - [`cd5b174`](https://github.com/Comfy-Org/desktop/commit/cd5b17448859eba279086a2f19d605eee75ab660) Remove dynamic imports - not required ### 📊 Changes **12 files changed** (+10 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/config/comfyConfigManager.test.ts` (+3 -13) 📝 `tests/unit/config/comfyServerConfig.test.ts` (+2 -10) 📝 `tests/unit/config/comfySettings.test.ts` (+0 -7) 📝 `tests/unit/desktopApp.test.ts` (+0 -7) 📝 `tests/unit/handlers/AppHandlers.test.ts` (+0 -6) 📝 `tests/unit/install/installWizard.test.ts` (+0 -1) 📝 `tests/unit/install/installationManager.test.ts` (+0 -1) 📝 `tests/unit/main-process/appWindow.test.ts` (+0 -7) 📝 `tests/unit/main-process/comfyDesktopApp.test.ts` (+0 -8) ➕ `tests/unit/setup.ts` (+3 -0) 📝 `tests/unit/store/desktopConfig.test.ts` (+0 -8) 📝 `vite.config.ts` (+2 -1) </details> ### 📄 Description - Adds global setup file for vitest - Automocks `electron-log/main` in all unit tests - Removes all manual mocking of that module ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-890-Test-Always-automock-electron-log-1986d73d36508188a403d22f7d08255f) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:13 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:01 +00:00

[PR #1185] [MERGED] [chore] Pin third-party GitHub Actions to commit SHAs #1391

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1185

No description provided.

Rows
Columns