[PR #468] [MERGED] Add GPU selection to installer #890

New issue

Closed

opened 2026-10-31 22:17:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/468
Author: @webfiltered
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @webfiltered

Base: main ← Head: do-that-gpu-thing

📝 Commits (10+)

205169c Add GPU choice to installation options
fd75298 Allow users to force CPU mode via config.json
ef08987 Allow frontend to set cpu startup setting
5f8ed43 Allow frontend to restart the python server
c65da39 Use detected GPU to pre-select install options
370769b Allow frontend to confirm which platform it is on
0386499 Add error wrapping for frontend settings checks
2bbade0 Allow frontend to see last validated GPU
e7c7ce0 Configure user-selected pytorch variant
3b88e6b Remove risk of IPC async context issues

📊 Changes

9 files changed (+480 additions, -17 deletions)

View changed files

➕ assets/requirements/windows_cpu.compiled (+340 -0)
📝 src/constants.ts (+2 -0)
📝 src/install/installWizard.ts (+6 -0)
📝 src/main-process/comfyDesktopApp.ts (+25 -3)
📝 src/preload.ts (+24 -0)
📝 src/store/desktopConfig.ts (+34 -0)
📝 src/store/index.ts (+9 -0)
📝 src/utils.ts (+5 -4)
📝 src/virtualEnvironment.ts (+35 -10)

📄 Description

GPU installation options

Adds GPU selection screen
If a supported GPU is detected, it is pre-selected
Allows user to pick whatever they wish
Installs the appropriate pytorch for the selection
Includes support for CPU mode
Adds flag that auto-starts in CPU mode
Stores selected GPU in config.json for future ref / debugging

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/468 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `do-that-gpu-thing` --- ### 📝 Commits (10+) - [`205169c`](https://github.com/Comfy-Org/desktop/commit/205169c700d57b9130439f93963762c3a8f93007) Add GPU choice to installation options - [`fd75298`](https://github.com/Comfy-Org/desktop/commit/fd75298285c089615991f2e0ea89af0a86bde0d2) Allow users to force CPU mode via config.json - [`ef08987`](https://github.com/Comfy-Org/desktop/commit/ef0898724e4611c0f868b17c59f0d89e964405f4) Allow frontend to set cpu startup setting - [`5f8ed43`](https://github.com/Comfy-Org/desktop/commit/5f8ed43b73bf1c687955b9bdbccdc1ff8c34fd44) Allow frontend to restart the python server - [`c65da39`](https://github.com/Comfy-Org/desktop/commit/c65da39bdefce067bcb21e0bb3cc1af8bfbf6168) Use detected GPU to pre-select install options - [`370769b`](https://github.com/Comfy-Org/desktop/commit/370769b90b221cf02c98ea49fdaae87061470c2e) Allow frontend to confirm which platform it is on - [`0386499`](https://github.com/Comfy-Org/desktop/commit/03864993d93aea12d1c37c3b7e4b4a69a60bf5e4) Add error wrapping for frontend settings checks - [`2bbade0`](https://github.com/Comfy-Org/desktop/commit/2bbade09d1f973a266c708e001b4634968c7b666) Allow frontend to see last validated GPU - [`e7c7ce0`](https://github.com/Comfy-Org/desktop/commit/e7c7ce0f98ae867efaeffda07b2f60ab2fc184c5) Configure user-selected pytorch variant - [`3b88e6b`](https://github.com/Comfy-Org/desktop/commit/3b88e6b2bd7ae77bfa2fad434ef34cc847254d5d) Remove risk of IPC async context issues ### 📊 Changes **9 files changed** (+480 additions, -17 deletions) <details> <summary>View changed files</summary> ➕ `assets/requirements/windows_cpu.compiled` (+340 -0) 📝 `src/constants.ts` (+2 -0) 📝 `src/install/installWizard.ts` (+6 -0) 📝 `src/main-process/comfyDesktopApp.ts` (+25 -3) 📝 `src/preload.ts` (+24 -0) 📝 `src/store/desktopConfig.ts` (+34 -0) 📝 `src/store/index.ts` (+9 -0) 📝 `src/utils.ts` (+5 -4) 📝 `src/virtualEnvironment.ts` (+35 -10) </details> ### 📄 Description ### GPU installation options - Adds GPU selection screen - If a supported GPU is detected, it is pre-selected - Allows user to pick whatever they wish - Installs the appropriate `pytorch` for the selection - Includes support for CPU mode - Adds flag that auto-starts in CPU mode - Stores selected GPU in config.json for future ref / debugging --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:47 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:13 +00:00

[PR #890] [MERGED] [Test] Always automock electron-log #1185

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#890

No description provided.

Rows
Columns