[PR #901] [MERGED] Split playwright tests into install and post-install projects #1191

New issue

Closed

opened 2026-10-31 22:20:16 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/901
Author: @christian-byrne
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @webfiltered

Base: main ← Head: cb-test-projects

📝 Commits (8)

204abb3 split tests into install and post-install projects
27bd088 add projects config
0ecf869 nit
823692b set per-project config
d745d70 move screenshots
19e4985 nit
128b2d6 append project name to screenshot filenames
5401e21 put use in global scope

📊 Changes

12 files changed (+18 additions, -5 deletions)

View changed files

📝 playwright.config.ts (+15 -2)
📝 tests/integration/install/installApp.spec.ts (+1 -1)
📝 tests/integration/install/installWizard.spec.ts (+1 -1)
📝 tests/integration/install/installWizard.spec.ts-snapshots/choose-installation-location-install-win32.png (+0 -0)
📝 tests/integration/install/installWizard.spec.ts-snapshots/cpu-clicked-install-win32.png (+0 -0)
➕ tests/integration/install/installWizard.spec.ts-snapshots/desktop-app-settings-install-win32.png (+0 -0)
📝 tests/integration/install/installWizard.spec.ts-snapshots/get-started-install-win32.png (+0 -0)
➕ tests/integration/install/installWizard.spec.ts-snapshots/migrate-from-existing-installation-install-win32.png (+0 -0)
📝 tests/integration/install/installWizard.spec.ts-snapshots/select-gpu-install-win32.png (+0 -0)
➖ tests/integration/installWizard.spec.ts-snapshots/desktop-app-settings-win32.png (+0 -0)
➖ tests/integration/installWizard.spec.ts-snapshots/migrate-from-existing-installation-win32.png (+0 -0)
📝 tests/integration/shared/appWindow.spec.ts (+1 -1)

📄 Description

Split playwright tests into install project and post-install project. Set install project as dependency of post-install project, so that it runs first. Create shared folder for test files that should be run against both pre-install and post-install state. Resolves #900.

Playwright project dependencies docs

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/901 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `cb-test-projects` --- ### 📝 Commits (8) - [`204abb3`](https://github.com/Comfy-Org/desktop/commit/204abb38ca7a0a16aa3167288d94b809cbb4ab4f) split tests into install and post-install projects - [`27bd088`](https://github.com/Comfy-Org/desktop/commit/27bd088b11eae341aa5e3172ae721a7d2c685af7) add projects config - [`0ecf869`](https://github.com/Comfy-Org/desktop/commit/0ecf8690b46bfee5fdf41ecc297fee948e0738f7) nit - [`823692b`](https://github.com/Comfy-Org/desktop/commit/823692b34ec0cf33ea37d74f62b23e29eb150628) set per-project config - [`d745d70`](https://github.com/Comfy-Org/desktop/commit/d745d70c660e8879c0613c319bed42e79afd6c65) move screenshots - [`19e4985`](https://github.com/Comfy-Org/desktop/commit/19e4985a3503df3e92558c6fcb49d02cb8074c36) nit - [`128b2d6`](https://github.com/Comfy-Org/desktop/commit/128b2d687afe89e3fcfa54fe8a1bcdf7d06ae233) append project name to screenshot filenames - [`5401e21`](https://github.com/Comfy-Org/desktop/commit/5401e21c2b2c9b37cc8d6a04fff567539c5b2dca) put use in global scope ### 📊 Changes **12 files changed** (+18 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `playwright.config.ts` (+15 -2) 📝 `tests/integration/install/installApp.spec.ts` (+1 -1) 📝 `tests/integration/install/installWizard.spec.ts` (+1 -1) 📝 `tests/integration/install/installWizard.spec.ts-snapshots/choose-installation-location-install-win32.png` (+0 -0) 📝 `tests/integration/install/installWizard.spec.ts-snapshots/cpu-clicked-install-win32.png` (+0 -0) ➕ `tests/integration/install/installWizard.spec.ts-snapshots/desktop-app-settings-install-win32.png` (+0 -0) 📝 `tests/integration/install/installWizard.spec.ts-snapshots/get-started-install-win32.png` (+0 -0) ➕ `tests/integration/install/installWizard.spec.ts-snapshots/migrate-from-existing-installation-install-win32.png` (+0 -0) 📝 `tests/integration/install/installWizard.spec.ts-snapshots/select-gpu-install-win32.png` (+0 -0) ➖ `tests/integration/installWizard.spec.ts-snapshots/desktop-app-settings-win32.png` (+0 -0) ➖ `tests/integration/installWizard.spec.ts-snapshots/migrate-from-existing-installation-win32.png` (+0 -0) 📝 `tests/integration/shared/appWindow.spec.ts` (+1 -1) </details> ### 📄 Description Split playwright tests into install project and post-install project. Set install project as dependency of post-install project, so that it runs first. Create `shared` folder for test files that should be run against both pre-install and post-install state. Resolves #900. [Playwright project dependencies docs](https://playwright.dev/docs/test-projects#dependencies) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-901-Split-playwright-tests-into-install-and-post-install-projects-19a6d73d36508105872cfbd1d35d9922) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:16 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:03 +00:00

[PR #1191] [MERGED] [feat] add optional bypass for disk space validation during installation #1395

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1191

No description provided.

Rows
Columns