[PR #1191] [MERGED] [feat] add optional bypass for disk space validation during installation #1395

New issue

Closed

opened 2026-10-31 22:22:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:22:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1191
Author: @christian-byrne
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @webfiltered

Base: main ← Head: feat/install-path-disk-space-bypass

📝 Commits (1)

ed7e5e1 [feat] add optional bypass for disk space validation during installation

📊 Changes

3 files changed (+54 additions, -5 deletions)

View changed files

📝 src/handlers/pathHandlers.ts (+2 -2)
📝 src/preload.ts (+6 -2)
📝 tests/unit/handlers/pathHandler.test.ts (+46 -1)

📄 Description

Allows users to bypass the 10GB (Windows) / 5GB (macOS) disk space requirement when selecting an installation path. The bypass only affects disk space validation while preserving all other path validation checks.

https://github.com/Comfy-Org/desktop/issues/1190

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1191 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `feat/install-path-disk-space-bypass` --- ### 📝 Commits (1) - [`ed7e5e1`](https://github.com/Comfy-Org/desktop/commit/ed7e5e1a7cd5f6e622a4e9bf3e4491f02aeeb05f) [feat] add optional bypass for disk space validation during installation ### 📊 Changes **3 files changed** (+54 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/pathHandlers.ts` (+2 -2) 📝 `src/preload.ts` (+6 -2) 📝 `tests/unit/handlers/pathHandler.test.ts` (+46 -1) </details> ### 📄 Description Allows users to bypass the 10GB (Windows) / 5GB (macOS) disk space requirement when selecting an installation path. The bypass only affects disk space validation while preserving all other path validation checks. https://github.com/Comfy-Org/desktop/issues/1190 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1191-feat-add-optional-bypass-for-disk-space-validation-during-installation-20c6d73d365081f6868cf3808c6c3c1f) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:22:03 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1395

No description provided.

Rows
Columns