[PR #905] [MERGED] [Test] Fix e2e CI timeouts #1194

New issue

Closed

opened 2026-10-31 22:20:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/905
Author: @webfiltered
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @webfiltered

Base: main ← Head: e2e-fix-timeout

📝 Commits (2)

a8a3783 [Test] Fix CI timeout on fresh install app start
8284dc5 Ensure app close() is only called once

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 tests/integration/testApp.ts (+5 -2)
📝 tests/integration/testInstallWizard.ts (+4 -1)

📄 Description

Fresh install app start - 60sec
Prevent race condition in app manual close vs dispose

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/905 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-fix-timeout` --- ### 📝 Commits (2) - [`a8a3783`](https://github.com/Comfy-Org/desktop/commit/a8a378322bbc3de03ca2e7eb08c312d235f08b8c) [Test] Fix CI timeout on fresh install app start - [`8284dc5`](https://github.com/Comfy-Org/desktop/commit/8284dc5d954c2fa4d375f4278e72ee199ce965ef) Ensure app close() is only called once ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/testApp.ts` (+5 -2) 📝 `tests/integration/testInstallWizard.ts` (+4 -1) </details> ### 📄 Description - Fresh install app start - 60sec - Prevent race condition in app manual close vs dispose ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-905-Test-Fix-e2e-CI-timeouts-19b6d73d365081c5a9a6d6608201f039) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:18 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1194

No description provided.

Rows
Columns