[PR #485] [MERGED] Code cleanup, logging #905

New issue

Closed

opened 2026-10-31 22:17:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/485
Author: @webfiltered
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @huchenlei

Base: main ← Head: clean-iii

📝 Commits (10+)

ab972ab Remove unused vars
66b2c7d Prefer unknown over explicit any
c45f0a1 Add TS types
3de3b87 nit
4082e50 nit
5fb325a Prefer const over let
d66cf1a Add TS types
8ec028c Remove unnecessary type assertion
fdb847e nit
8311046 Add TS type

📊 Changes

9 files changed (+57 additions, -39 deletions)

View changed files

📝 src/handlers/pathHandlers.ts (+2 -2)
📝 src/install/installationValidator.ts (+2 -2)
📝 src/main-process/appWindow.ts (+3 -3)
📝 src/main-process/comfyDesktopApp.ts (+26 -18)
📝 src/main.ts (+3 -1)
📝 src/models/DownloadManager.ts (+15 -4)
📝 src/preload.ts (+2 -5)
📝 src/services/sentry.ts (+2 -2)
📝 src/virtualEnvironment.ts (+2 -2)

📄 Description

Clean up - Part III

Based on #484
Adds startup error logs, ensuring app lifecycle can be properly traced in main.log
Removes unused vars
Removes explicit any
TS types
Various nits

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/485 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `clean-iii` --- ### 📝 Commits (10+) - [`ab972ab`](https://github.com/Comfy-Org/desktop/commit/ab972abb4666f1786ffcc866b228a88e91be05bc) Remove unused vars - [`66b2c7d`](https://github.com/Comfy-Org/desktop/commit/66b2c7d72343ce0a3dbaf2fd1fe2b58d5e30d6b2) Prefer unknown over explicit any - [`c45f0a1`](https://github.com/Comfy-Org/desktop/commit/c45f0a1612b3178f23c132b039bb7e2118786c2c) Add TS types - [`3de3b87`](https://github.com/Comfy-Org/desktop/commit/3de3b87f6b7891412f2790a88009b39fc0f26cbf) nit - [`4082e50`](https://github.com/Comfy-Org/desktop/commit/4082e503ce3efc79ad7ad63b6d6e365cc6d36b68) nit - [`5fb325a`](https://github.com/Comfy-Org/desktop/commit/5fb325a09a791ba6b50b3a38eca12d11241d9b6e) Prefer const over let - [`d66cf1a`](https://github.com/Comfy-Org/desktop/commit/d66cf1aaac1fee7cc1eefe5412513a215e05e21b) Add TS types - [`8ec028c`](https://github.com/Comfy-Org/desktop/commit/8ec028cb911765a2f9e6d0b2dcaa427192d97c4d) Remove unnecessary type assertion - [`fdb847e`](https://github.com/Comfy-Org/desktop/commit/fdb847e288a4e0bc88330558841701782fd4215e) nit - [`8311046`](https://github.com/Comfy-Org/desktop/commit/8311046cdcfabca9636ea5c2aa4afe1f2e157c41) Add TS type ### 📊 Changes **9 files changed** (+57 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/pathHandlers.ts` (+2 -2) 📝 `src/install/installationValidator.ts` (+2 -2) 📝 `src/main-process/appWindow.ts` (+3 -3) 📝 `src/main-process/comfyDesktopApp.ts` (+26 -18) 📝 `src/main.ts` (+3 -1) 📝 `src/models/DownloadManager.ts` (+15 -4) 📝 `src/preload.ts` (+2 -5) 📝 `src/services/sentry.ts` (+2 -2) 📝 `src/virtualEnvironment.ts` (+2 -2) </details> ### 📄 Description ### Clean up - Part III - Based on #484 - Adds startup error logs, ensuring app lifecycle can be properly traced in `main.log` - Removes unused vars - Removes explicit `any` - TS types - Various nits --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:55 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:19 +00:00

[PR #905] [MERGED] [Test] Fix e2e CI timeouts #1194

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#905

No description provided.

Rows
Columns