[PR #907] [MERGED] [e2e] Implement install process for post-install tests #1195

New issue

Closed

opened 2026-10-31 22:20:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/907
Author: @webfiltered
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @webfiltered

Base: main ← Head: e2e-install

📝 Commits (8)

3cba95a Ensure install test disposes test env
4647f4e nit
9649815 Add post-install setup project
f7e9c95 [Refactor] Re-export expect to enable custom tests
b88a1eb [Refactor] Use class properties for locators
00849a5 Add post-install app setup "test"
ee1fcf9 [Refactor] Set dispose test environment at project level
b0c7944 [DevExp] Use soft fail for install location

📊 Changes

9 files changed (+82 additions, -27 deletions)

View changed files

📝 playwright.config.ts (+12 -2)
📝 tests/integration/install/installApp.spec.ts (+6 -10)
📝 tests/integration/install/installWizard.spec.ts (+6 -8)
➕ tests/integration/post-install.setup.ts (+34 -0)
📝 tests/integration/shared/appWindow.spec.ts (+1 -3)
📝 tests/integration/testExtensions.ts (+4 -2)
📝 tests/integration/testGraphCanvas.ts (+3 -1)
📝 tests/integration/testInstallWizard.ts (+14 -0)
📝 tests/integration/testInstalledApp.ts (+2 -1)

📄 Description

Cleans up test classes / interfaces.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/907 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-install` --- ### 📝 Commits (8) - [`3cba95a`](https://github.com/Comfy-Org/desktop/commit/3cba95aaf23a183cf7ec34cd2ef604a57079dcb8) Ensure install test disposes test env - [`4647f4e`](https://github.com/Comfy-Org/desktop/commit/4647f4e88cdfdf0fc7e680115e70ef8a3daf5218) nit - [`9649815`](https://github.com/Comfy-Org/desktop/commit/96498150680d88f060541bd1dd5d7420b29d4593) Add post-install setup project - [`f7e9c95`](https://github.com/Comfy-Org/desktop/commit/f7e9c951254593560719933aebb332e5e155b14b) [Refactor] Re-export expect to enable custom tests - [`b88a1eb`](https://github.com/Comfy-Org/desktop/commit/b88a1eb6d3cfc2c850cd7433abbcda587e52c524) [Refactor] Use class properties for locators - [`00849a5`](https://github.com/Comfy-Org/desktop/commit/00849a55d357d330a280c7f87a2ed68223c0c33e) Add post-install app setup "test" - [`ee1fcf9`](https://github.com/Comfy-Org/desktop/commit/ee1fcf95880c210d81b14100c3e0f1a7c8f5c461) [Refactor] Set dispose test environment at project level - [`b0c7944`](https://github.com/Comfy-Org/desktop/commit/b0c794418b3d17a0d1099775db512e699610e10c) [DevExp] Use soft fail for install location ### 📊 Changes **9 files changed** (+82 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `playwright.config.ts` (+12 -2) 📝 `tests/integration/install/installApp.spec.ts` (+6 -10) 📝 `tests/integration/install/installWizard.spec.ts` (+6 -8) ➕ `tests/integration/post-install.setup.ts` (+34 -0) 📝 `tests/integration/shared/appWindow.spec.ts` (+1 -3) 📝 `tests/integration/testExtensions.ts` (+4 -2) 📝 `tests/integration/testGraphCanvas.ts` (+3 -1) 📝 `tests/integration/testInstallWizard.ts` (+14 -0) 📝 `tests/integration/testInstalledApp.ts` (+2 -1) </details> ### 📄 Description Cleans up test classes / interfaces. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-907-e2e-Implement-install-process-for-post-install-tests-19b6d73d3650819d9366c972db13e20b) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:19 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:03 +00:00

[PR #1195] feat: add Custom Launch Arguments #1396

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1195

No description provided.

Rows
Columns