[PR #488] [MERGED] Standardise & simplify code #907

New issue

Closed

opened 2026-10-31 22:17:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/488
Author: @webfiltered
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @huchenlei

Base: main ← Head: eslint-clean

📝 Commits (7)

0d1cbae nit - Standardise imports
6962a41 nit - Doc
819b1b8 nit - Standardise error var names
bf2a38f nit - Standardise utf8 name
dfb2c05 [Refactor] Simplify code - prefer spread, for-of
47a96fb [Refactor] Assorted ESLint nits
86b1365 Fix test import / mock

📊 Changes

21 files changed (+79 additions, -80 deletions)

View changed files

📝 scripts/env.mjs (+1 -1)
📝 src/config/comfyConfigManager.ts (+4 -4)
📝 src/config/comfyServerConfig.ts (+7 -6)
📝 src/config/comfySettings.ts (+3 -3)
📝 src/handlers/pathHandlers.ts (+2 -2)
📝 src/install/installWizard.ts (+2 -2)
📝 src/install/installationValidator.ts (+1 -1)
📝 src/install/resourcePaths.ts (+1 -1)
📝 src/main-process/comfyDesktopApp.ts (+9 -12)
📝 src/main-process/comfyServer.ts (+9 -9)
📝 src/main.ts (+2 -2)
📝 src/models/DownloadManager.ts (+3 -3)
📝 src/preload.ts (+1 -1)
📝 src/services/backup.ts (+8 -8)
📝 src/shell/terminal.ts (+1 -1)
📝 src/shell/util.ts (+1 -1)
📝 src/store/desktopConfig.ts (+2 -1)
📝 src/utils.ts (+7 -7)
📝 src/virtualEnvironment.ts (+11 -11)
📝 tests/unit/comfyConfigManager.test.ts (+2 -2)

...and 1 more files

📄 Description

Cleans imports
Always use error for error var
Prefer spread, for-of, and anything-but-reduce
And various other ESLint nits

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/488 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `eslint-clean` --- ### 📝 Commits (7) - [`0d1cbae`](https://github.com/Comfy-Org/desktop/commit/0d1cbaec32b64fcb2036775db8769481b90b4703) nit - Standardise imports - [`6962a41`](https://github.com/Comfy-Org/desktop/commit/6962a41590e5e0ba6d8e3a21ca76aa0cbdb55898) nit - Doc - [`819b1b8`](https://github.com/Comfy-Org/desktop/commit/819b1b8d74066d04a32e3a06de5a2f58e8073469) nit - Standardise error var names - [`bf2a38f`](https://github.com/Comfy-Org/desktop/commit/bf2a38f22c9cb9074487573da05a151d113ef8a2) nit - Standardise utf8 name - [`dfb2c05`](https://github.com/Comfy-Org/desktop/commit/dfb2c05f6688b53ec9af98cdd8152ca09a3fca8f) [Refactor] Simplify code - prefer spread, for-of - [`47a96fb`](https://github.com/Comfy-Org/desktop/commit/47a96fb11f88284be184fb4284613319df5ed186) [Refactor] Assorted ESLint nits - [`86b1365`](https://github.com/Comfy-Org/desktop/commit/86b1365123cb546c4a03c16881513a51535678ef) Fix test import / mock ### 📊 Changes **21 files changed** (+79 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `scripts/env.mjs` (+1 -1) 📝 `src/config/comfyConfigManager.ts` (+4 -4) 📝 `src/config/comfyServerConfig.ts` (+7 -6) 📝 `src/config/comfySettings.ts` (+3 -3) 📝 `src/handlers/pathHandlers.ts` (+2 -2) 📝 `src/install/installWizard.ts` (+2 -2) 📝 `src/install/installationValidator.ts` (+1 -1) 📝 `src/install/resourcePaths.ts` (+1 -1) 📝 `src/main-process/comfyDesktopApp.ts` (+9 -12) 📝 `src/main-process/comfyServer.ts` (+9 -9) 📝 `src/main.ts` (+2 -2) 📝 `src/models/DownloadManager.ts` (+3 -3) 📝 `src/preload.ts` (+1 -1) 📝 `src/services/backup.ts` (+8 -8) 📝 `src/shell/terminal.ts` (+1 -1) 📝 `src/shell/util.ts` (+1 -1) 📝 `src/store/desktopConfig.ts` (+2 -1) 📝 `src/utils.ts` (+7 -7) 📝 `src/virtualEnvironment.ts` (+11 -11) 📝 `tests/unit/comfyConfigManager.test.ts` (+2 -2) _...and 1 more files_ </details> ### 📄 Description - Cleans imports - Always use `error` for error var - Prefer spread, for-of, and anything-but-reduce - And various other ESLint nits --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:55 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:19 +00:00

[PR #907] [MERGED] [e2e] Implement install process for post-install tests #1195

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#907

No description provided.

Rows
Columns