[PR #939] [MERGED] Prevent unexpected error message on window close #1219

New issue

Closed

opened 2026-10-31 22:20:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/939
Author: @webfiltered
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @webfiltered

Base: main ← Head: unexpected-race

📝 Commits (1)

c39a922 Prevent unexpected error message on window close

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 src/main-process/appWindow.ts (+6 -3)

📄 Description

Guards against unhandled exception error dialog when closing the app during app start, by closing the window.

Requires losing a tight async race; this should not have been experienced by many users.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/939 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `unexpected-race` --- ### 📝 Commits (1) - [`c39a922`](https://github.com/Comfy-Org/desktop/commit/c39a92217673c82f0aa3b2dfc1703db60e2cbcbf) Prevent unexpected error message on window close ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+6 -3) </details> ### 📄 Description Guards against unhandled exception error dialog when closing the app during app start, by closing the window. Requires losing a tight async race; this should not have been experienced by many users. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-939-Prevent-unexpected-error-message-on-window-close-19e6d73d3650814fb5f1d8db7e7d0665) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:33 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:12 +00:00

[PR #1219] [MERGED] v0.4.55: Bump ComfyUI + templates for moonvalley. #1414

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1219

No description provided.

Rows
Columns