[PR #567] [MERGED] Export all API types #939

New issue

Closed

opened 2026-10-31 22:18:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/567
Author: @webfiltered
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/28/2024
Merged by: @robinjhuang

Base: main ← Head: preload-types

📝 Commits (2)

8f6941d Allow preload types to be used in frontend
694c276 Fix enum imported via meta file

📊 Changes

2 files changed (+11 additions, -3 deletions)

View changed files

📝 src/main_types.ts (+10 -1)
📝 src/models/DownloadManager.ts (+1 -2)

📄 Description

Allows all API types to be imported
Removes need to redeclare types in frontend (e.g. via Parameters<> decls)
Fixes a local type import that was using the main_types API entry point

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/567 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `preload-types` --- ### 📝 Commits (2) - [`8f6941d`](https://github.com/Comfy-Org/desktop/commit/8f6941d56fe7038b26f083a47048cd2cf46cc7a9) Allow preload types to be used in frontend - [`694c276`](https://github.com/Comfy-Org/desktop/commit/694c2763cbdd3e84aff0cc7e2a7609b030d1a16a) Fix enum imported via meta file ### 📊 Changes **2 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/main_types.ts` (+10 -1) 📝 `src/models/DownloadManager.ts` (+1 -2) </details> ### 📄 Description - Allows all API types to be imported - Removes need to redeclare types in frontend (e.g. via `Parameters<>` decls) - Fixes a local type import that was using the `main_types` API entry point ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-567-Export-all-API-types-1686d73d365081d3b481f28851890d15) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:13 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:33 +00:00

[PR #939] [MERGED] Prevent unexpected error message on window close #1219

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#939

No description provided.

Rows
Columns