[PR #959] [MERGED] [Test] Impl. proper unit test infrastructure for AppState #1234

New issue

Closed

opened 2026-10-31 22:20:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/959
Author: @webfiltered
Created: 2/19/2025
Status: ✅ Merged
Merged: 2/19/2025
Merged by: @webfiltered

Base: main ← Head: app-state-test

📝 Commits (1)

67076bc [Test] Impl. proper test infrastructure in AppState

📊 Changes

2 files changed (+114 additions, -106 deletions)

View changed files

📝 .cursor/rules/vitest.mdc (+1 -1)
📝 tests/unit/main-process/appState.test.ts (+113 -105)

📄 Description

Prefer extending test over loose variables / describe config
Centralises setup / teardown
Tests automatically use only what is required - no special cases needed
Simplifies test code

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/959 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/19/2025 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `app-state-test` --- ### 📝 Commits (1) - [`67076bc`](https://github.com/Comfy-Org/desktop/commit/67076bc112a44fab21df0a4e2b7e3fd6ef1538e7) [Test] Impl. proper test infrastructure in AppState ### 📊 Changes **2 files changed** (+114 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `.cursor/rules/vitest.mdc` (+1 -1) 📝 `tests/unit/main-process/appState.test.ts` (+113 -105) </details> ### 📄 Description - Prefer extending `test` over loose variables / describe config - Centralises setup / teardown - Tests automatically use only what is required - no special cases needed - Simplifies test code ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-959-Test-Impl-proper-unit-test-infrastructure-for-AppState-19f6d73d365081048b59fd29469e6328) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:42 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1234

No description provided.

Rows
Columns