[PR #609] [MERGED] [Cleanup] Remove electronAPI.sendErrorToSentry #959

New issue

Closed

opened 2026-10-31 22:18:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/609
Author: @huchenlei
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @huchenlei

Base: main ← Head: remove_sentry_api

📝 Commits (1)

51fe97c [Cleanup] Remove reportSentryError in electronAPI

📊 Changes

4 files changed (+1 additions, -36 deletions)

View changed files

📝 src/constants.ts (+0 -1)
📝 src/main-process/comfyDesktopApp.ts (+0 -23)
📝 src/preload.ts (+0 -8)
📝 src/services/sentry.ts (+1 -4)

📄 Description

https://github.com/Comfy-Org/ComfyUI_frontend/pull/2229 now directly call Sentry endpoint in the frontend. The electron API for Sentry reporting can be dropped.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/609 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `remove_sentry_api` --- ### 📝 Commits (1) - [`51fe97c`](https://github.com/Comfy-Org/desktop/commit/51fe97c48f963b4074f9a8cb672b900bbe581984) [Cleanup] Remove reportSentryError in electronAPI ### 📊 Changes **4 files changed** (+1 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+0 -1) 📝 `src/main-process/comfyDesktopApp.ts` (+0 -23) 📝 `src/preload.ts` (+0 -8) 📝 `src/services/sentry.ts` (+1 -4) </details> ### 📄 Description https://github.com/Comfy-Org/ComfyUI_frontend/pull/2229 now directly call Sentry endpoint in the frontend. The electron API for Sentry reporting can be dropped. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:21 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:42 +00:00

[PR #959] [MERGED] [Test] Impl. proper unit test infrastructure for AppState #1234

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#959

No description provided.

Rows
Columns