[PR #972] [MERGED] [Test] Globally mock sentry and telemetry #1248

New issue

Closed

opened 2026-10-31 22:20:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/972
Author: @webfiltered
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @webfiltered

Base: main ← Head: global-mocks

📝 Commits (1)

335af41 [Test] Globally mock sentry and telemetry

📊 Changes

3 files changed (+35 additions, -17 deletions)

View changed files

📝 tests/unit/install/installWizard.test.ts (+11 -17)
📝 tests/unit/services/telemetry.test.ts (+3 -0)
📝 tests/unit/setup.ts (+21 -0)

📄 Description

Makes tests less brittle by mocking global singletons once during setup.
Unmocked at start of relevant test files

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/972 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `global-mocks` --- ### 📝 Commits (1) - [`335af41`](https://github.com/Comfy-Org/desktop/commit/335af4133bc7ceae8e38ac34199ef8504c2e9a71) [Test] Globally mock sentry and telemetry ### 📊 Changes **3 files changed** (+35 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/install/installWizard.test.ts` (+11 -17) 📝 `tests/unit/services/telemetry.test.ts` (+3 -0) 📝 `tests/unit/setup.ts` (+21 -0) </details> ### 📄 Description - Makes tests less brittle by mocking global singletons once during setup. - Unmocked at start of relevant test files ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-972-Test-Globally-mock-sentry-and-telemetry-1a16d73d365081ada2cbfb8acc5be309) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:47 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:21 +00:00

[PR #1248] Add VC++ to the Windows installer #1436

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1248

No description provided.

Rows
Columns