[PR #1248] Add VC++ to the Windows installer #1436

New issue

Open

opened 2026-10-31 22:22:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:22:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1248
Author: @webfiltered
Created: 8/14/2025
Status: 🔄 Open

Base: main ← Head: vcpp-installer

📝 Commits (10+)

8c94335 Add bundled VC++ installation
7d9d58f Add VC++ to installer - first pass
64db142 Only download VC++ when publishing
2ac921b Revert VC++ download via conditional build
5eac5b2 Download VC++ in toDesktop script
053019d Move VC++ download to afterPack hook
9b7d907 Fix VC++ download path to use BUILD_RESOURCES_DIR
24f9fb0 Add BUILD_RESOURCES_DIR env var logging
ddc34d2 Improve VC++ installer UX with banner and nsExec
0f28904 Remove trailing whitespace from blank lines

📊 Changes

2 files changed (+128 additions, -2 deletions)

View changed files

📝 scripts/installer.nsh (+99 -2)
📝 scripts/todesktop/afterPack.cjs (+29 -0)

📄 Description

Overview

Bundle Visual C++ Redistributable with Windows installer to ensure runtime dependencies are met.

User Impact

Removes the requirement for users to manually download and install VC++ redistributable.

Key Changes

Automatically download & install VC++ redistributable during build process
Ensure admin elevation prompt is displayed in foreground

Implementation

afterPack.cjs: Downloads redistributable from Microsoft during build
installer.nsh: Checks for and installs VC++ during installation with proper UAC handling

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1248 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 8/14/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `vcpp-installer` --- ### 📝 Commits (10+) - [`8c94335`](https://github.com/Comfy-Org/desktop/commit/8c94335efc73c578e716a125eb8e348cb2f84f0c) Add bundled VC++ installation - [`7d9d58f`](https://github.com/Comfy-Org/desktop/commit/7d9d58f6ddcbfb9fb89c3221d0523cec587d5f28) Add VC++ to installer - first pass - [`64db142`](https://github.com/Comfy-Org/desktop/commit/64db1424305457bff7a7bd07c675472a96b77920) Only download VC++ when publishing - [`2ac921b`](https://github.com/Comfy-Org/desktop/commit/2ac921b884182a7dfde93772bf17d7314b18bfaf) Revert VC++ download via conditional build - [`5eac5b2`](https://github.com/Comfy-Org/desktop/commit/5eac5b2f83f8c6a8f000224e9997db4504c06ba2) Download VC++ in toDesktop script - [`053019d`](https://github.com/Comfy-Org/desktop/commit/053019dd75cdd7186edf7c2a6aaa0b2c01c96dc7) Move VC++ download to afterPack hook - [`9b7d907`](https://github.com/Comfy-Org/desktop/commit/9b7d90731c18eee44b9f2048b164ccf0503d4ccd) Fix VC++ download path to use BUILD_RESOURCES_DIR - [`24f9fb0`](https://github.com/Comfy-Org/desktop/commit/24f9fb074c76067d5f0ab902309baf60f3502aa2) Add BUILD_RESOURCES_DIR env var logging - [`ddc34d2`](https://github.com/Comfy-Org/desktop/commit/ddc34d2d235d0fca9a65860767999b00655dcfb9) Improve VC++ installer UX with banner and nsExec - [`0f28904`](https://github.com/Comfy-Org/desktop/commit/0f28904dd09c3582eec1f83016fbe64e34a7b583) Remove trailing whitespace from blank lines ### 📊 Changes **2 files changed** (+128 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `scripts/installer.nsh` (+99 -2) 📝 `scripts/todesktop/afterPack.cjs` (+29 -0) </details> ### 📄 Description ### Overview Bundle Visual C++ Redistributable with Windows installer to ensure runtime dependencies are met. ### User Impact Removes the requirement for users to manually download and install VC++ redistributable. ### Key Changes - Automatically download & install VC++ redistributable during build process - Ensure admin elevation prompt is displayed in foreground ### Implementation - `afterPack.cjs`: Downloads redistributable from Microsoft during build - `installer.nsh`: Checks for and installs VC++ during installation with proper UAC handling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 22:22:21 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1436

No description provided.

Rows
Columns