[PR #973] [MERGED] [Test] Update unit tests to reflect recent changes #1249

New issue

Closed

opened 2026-10-31 22:20:49 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/973
Author: @webfiltered
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @webfiltered

Base: main ← Head: update-tests

📝 Commits (5)

e3b79bd nit
83b6cd4 [Test] Update tests with recent changes
44c05f8 [Test] Update cursor rules - unit tests
bb56dd6 Fix global property edits leaked in unit tests
6b1294a [Test] Fix inter-test state leak

📊 Changes

3 files changed (+184 additions, -12 deletions)

View changed files

📝 .cursor/rules/vitest.mdc (+8 -3)
📝 tests/unit/config/comfyConfigManager.test.ts (+76 -2)
📝 tests/unit/config/comfyServerConfig.test.ts (+100 -7)

📄 Description

Includes slight improvement to unit test cursor rules

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/973 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `update-tests` --- ### 📝 Commits (5) - [`e3b79bd`](https://github.com/Comfy-Org/desktop/commit/e3b79bd1ca9aed5bb3b045cfe56083d3f0f0a0c0) nit - [`83b6cd4`](https://github.com/Comfy-Org/desktop/commit/83b6cd4553b82fd4f749304842169c9c75ced661) [Test] Update tests with recent changes - [`44c05f8`](https://github.com/Comfy-Org/desktop/commit/44c05f8b1b12323a7ad8c6482b4d455e139a44f9) [Test] Update cursor rules - unit tests - [`bb56dd6`](https://github.com/Comfy-Org/desktop/commit/bb56dd60b7929913d27f0761cb227352dc7c35f2) Fix global property edits leaked in unit tests - [`6b1294a`](https://github.com/Comfy-Org/desktop/commit/6b1294a038701e6b4491e2227cbd2074fadf58da) [Test] Fix inter-test state leak ### 📊 Changes **3 files changed** (+184 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.cursor/rules/vitest.mdc` (+8 -3) 📝 `tests/unit/config/comfyConfigManager.test.ts` (+76 -2) 📝 `tests/unit/config/comfyServerConfig.test.ts` (+100 -7) </details> ### 📄 Description - Includes slight improvement to unit test cursor rules ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-973-Test-Update-unit-tests-to-reflect-recent-changes-1a16d73d3650814caecef44b5763c693) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:49 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1249

No description provided.

Rows
Columns