[PR #623] [MERGED] [Cleanup] Remove comfy-cli dependency #973

New issue

Closed

opened 2026-10-31 22:18:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/623
Author: @huchenlei
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/15/2025
Merged by: @huchenlei

Base: main ← Head: remove_cli

📝 Commits (4)

87cdf8c [Cleanup] Remove comfy-cli dependency
716b306 nit
0f3c28d nit
36d85df nit

📊 Changes

13 files changed (+20 additions, -83 deletions)

View changed files

📝 .github/actions/build/linux/app/action.yml (+2 -6)
📝 .github/actions/build/macos/comfy/action.yml (+1 -2)
📝 .github/actions/build/todesktop/action.yml (+1 -2)
📝 .github/actions/build/windows/app/action.yml (+2 -6)
📝 .github/workflows/debug_linux.yml (+0 -1)
📝 .github/workflows/debug_windows.yml (+0 -1)
📝 .github/workflows/integration_test_windows.yml (+0 -1)
📝 .github/workflows/publish_windows.yml (+0 -1)
📝 .github/workflows/todesktop.yml (+0 -1)
📝 README.md (+4 -17)
📝 package.json (+1 -4)
📝 scripts/makeComfy.js (+7 -37)
📝 scripts/preMake.js (+2 -4)

📄 Description

Follow-up on https://github.com/Comfy-Org/desktop/pull/622

https://github.com/Comfy-Org/desktop/pull/468 makes device selection happen at install time. The torch dependency auto installed by comfy-cli is now unused, but still takes significant amount of time for any developer who is setting up the project.

Currently what comfy-cli does is essentially checking out ComfyUI and ComfyUI-Manager. So this PR drops the dependency on comfy-cli and do the setup in plain git commands. This PR also removes the build-gpu arg in the build as they don't make any sense if we are not installing torch.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/623 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/15/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `remove_cli` --- ### 📝 Commits (4) - [`87cdf8c`](https://github.com/Comfy-Org/desktop/commit/87cdf8c9172438e677c16fca62c5b353175361e1) [Cleanup] Remove comfy-cli dependency - [`716b306`](https://github.com/Comfy-Org/desktop/commit/716b306a8ef7da1431a8c44ee907816d7c9920a5) nit - [`0f3c28d`](https://github.com/Comfy-Org/desktop/commit/0f3c28dfef6a9478550d49cc9a1eb4778792ee4a) nit - [`36d85df`](https://github.com/Comfy-Org/desktop/commit/36d85df2cc3c3f703b05dffc2332b070425eec52) nit ### 📊 Changes **13 files changed** (+20 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/linux/app/action.yml` (+2 -6) 📝 `.github/actions/build/macos/comfy/action.yml` (+1 -2) 📝 `.github/actions/build/todesktop/action.yml` (+1 -2) 📝 `.github/actions/build/windows/app/action.yml` (+2 -6) 📝 `.github/workflows/debug_linux.yml` (+0 -1) 📝 `.github/workflows/debug_windows.yml` (+0 -1) 📝 `.github/workflows/integration_test_windows.yml` (+0 -1) 📝 `.github/workflows/publish_windows.yml` (+0 -1) 📝 `.github/workflows/todesktop.yml` (+0 -1) 📝 `README.md` (+4 -17) 📝 `package.json` (+1 -4) 📝 `scripts/makeComfy.js` (+7 -37) 📝 `scripts/preMake.js` (+2 -4) </details> ### 📄 Description Follow-up on https://github.com/Comfy-Org/desktop/pull/622 https://github.com/Comfy-Org/desktop/pull/468 makes device selection happen at install time. The torch dependency auto installed by `comfy-cli` is now unused, but still takes significant amount of time for any developer who is setting up the project. Currently what `comfy-cli` does is essentially checking out ComfyUI and ComfyUI-Manager. So this PR drops the dependency on `comfy-cli` and do the setup in plain git commands. This PR also removes the `build-gpu` arg in the build as they don't make any sense if we are not installing torch. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-623-Cleanup-Remove-comfy-cli-dependency-17b6d73d365081c8b399c8c3dd5bca98) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:26 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:49 +00:00

[PR #973] [MERGED] [Test] Update unit tests to reflect recent changes #1249

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#973

No description provided.

Rows
Columns