[PR #118] [MERGED] Fix python install record file on Windows #623

New issue

Closed

opened 2026-10-31 22:15:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/118
Author: @huchenlei
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @huchenlei

Base: main ← Head: fix_install_record

📝 Commits (2)

36aa0de Fix python install record file on Windows
2b56dd3 nit

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/pythonEnvironment.ts (+1 -1)

📄 Description

Resolves https://github.com/Comfy-Org/electron/issues/121

Windows:
- Windows does NOT allow a file and directory to have the same name in the same parent directory
- This is case-insensitive, so you can't have "folder" and "Folder" or "file.txt" and "FILE.txt"

Unix-like systems (Linux, macOS, BSD):
- You CAN have a file and directory with the same exact name in the same parent directory
- These systems are case-sensitive by default, so "folder", "Folder", and "FOLDER" can all exist simultaneously
- Example: You can have both "/home/user/documents" (directory) and "/home/user/documents" (file)

The legacy python record path was something like electron/assets/python/python.exe/INSTALLER, which does not work on Windows. This PR fixes the issue by moving the record file under python root, i.e. electron/assets/python/INSTALLER.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/118 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_install_record` --- ### 📝 Commits (2) - [`36aa0de`](https://github.com/Comfy-Org/desktop/commit/36aa0de78bfdaaf2e248d436558aa15d949c75af) Fix python install record file on Windows - [`2b56dd3`](https://github.com/Comfy-Org/desktop/commit/2b56dd39a5d96453c384e2d28f38c20d832f3a3e) nit ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/pythonEnvironment.ts` (+1 -1) </details> ### 📄 Description Resolves https://github.com/Comfy-Org/electron/issues/121 ``` Windows: - Windows does NOT allow a file and directory to have the same name in the same parent directory - This is case-insensitive, so you can't have "folder" and "Folder" or "file.txt" and "FILE.txt" Unix-like systems (Linux, macOS, BSD): - You CAN have a file and directory with the same exact name in the same parent directory - These systems are case-sensitive by default, so "folder", "Folder", and "FOLDER" can all exist simultaneously - Example: You can have both "/home/user/documents" (directory) and "/home/user/documents" (file) ``` The legacy python record path was something like `electron/assets/python/python.exe/INSTALLER`, which does not work on Windows. This PR fixes the issue by moving the record file under python root, i.e. `electron/assets/python/INSTALLER`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:21 +00:00