[PR #981] [MERGED] [Test] Prefer vi.stubGlobal over direct object assignment #1254

New issue

Closed

opened 2026-10-31 22:20:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/981
Author: @webfiltered
Created: 2/22/2025
Status: ✅ Merged
Merged: 2/22/2025
Merged by: @webfiltered

Base: main ← Head: test-utils

📝 Commits (1)

be0659d Prefer vi.stubGlobal over direct object assignment

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 tests/unit/utils.test.ts (+4 -4)

📄 Description

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/981 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/22/2025 **Status:** ✅ Merged **Merged:** 2/22/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `test-utils` --- ### 📝 Commits (1) - [`be0659d`](https://github.com/Comfy-Org/desktop/commit/be0659d1bfdff4b97b87be1b7b08174696227d6f) Prefer vi.stubGlobal over direct object assignment ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/utils.test.ts` (+4 -4) </details> ### 📄 Description ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-981-Test-Prefer-vi-stubGlobal-over-direct-object-assignment-1a26d73d365081a88e14df4dbbfb1bac) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:52 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:21 +00:00

[PR #1254] [MERGED] [CI] Remove unstable frontend from Claude release #1434

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1254

No description provided.

Rows
Columns