[PR #636] [MERGED] Enable eslint in Github CI #981

New issue

Closed

opened 2026-10-31 22:18:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/636
Author: @huchenlei
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @huchenlei

Base: main ← Head: eslint2

📝 Commits (3)

a37cd43 Enable eslint in CI
2e3d380 lint only src
f0a8d35 Fix/Ignore lint errors

📊 Changes

4 files changed (+34 additions, -19 deletions)

View changed files

📝 .github/workflows/ci.yaml (+3 -0)
📝 package.json (+2 -2)
📝 src/main-process/comfyDesktopApp.ts (+1 -1)
📝 src/services/telemetry.ts (+28 -16)

📄 Description

This PR adds eslint to github CI so it is always enforces. It also fixes/ignores lint errors introduced in https://github.com/Comfy-Org/desktop/pull/617.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/636 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `eslint2` --- ### 📝 Commits (3) - [`a37cd43`](https://github.com/Comfy-Org/desktop/commit/a37cd43998287d7bb488e65387d0365e4d336b3d) Enable eslint in CI - [`2e3d380`](https://github.com/Comfy-Org/desktop/commit/2e3d38074c1960265f74eaeabeb2edf4e548d75d) lint only src - [`f0a8d35`](https://github.com/Comfy-Org/desktop/commit/f0a8d35eb9c4d2fda9c050a63db05ff0ef8c1fd4) Fix/Ignore lint errors ### 📊 Changes **4 files changed** (+34 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+3 -0) 📝 `package.json` (+2 -2) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -1) 📝 `src/services/telemetry.ts` (+28 -16) </details> ### 📄 Description This PR adds eslint to github CI so it is always enforces. It also fixes/ignores lint errors introduced in https://github.com/Comfy-Org/desktop/pull/617. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-636-Enable-eslint-in-Github-CI-17d6d73d365081848215de918becd7ee) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:30 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:52 +00:00

[PR #981] [MERGED] [Test] Prefer vi.stubGlobal over direct object assignment #1254

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#981

No description provided.

Rows
Columns