mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[PR #136] [MERGED] toDesktop Fixed Mac, Cleaned Up, Documented. #636
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#636
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/desktop/pull/136
Author: @KenCorma
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @KenCorma
Base:
main← Head:dev-kendal-fix-mac📝 Commits (5)
4aca6b1Just upload these files29b0e04This should fix the issueb877505Cleaned up and added Documentationdea06f3Format Fix3e368c1Bumped up Icon size📊 Changes
16 files changed (+62 additions, -307 deletions)
View changed files
📝
.github/actions/build/windows/todesktop/action.yml(+2 -2)📝
.github/workflows/publish_linux.yml(+1 -0)📝
.github/workflows/publish_macos.yml(+1 -0)📝
.github/workflows/publish_windows.yml(+1 -0)➕
assets/output/bin/python3.12(+0 -0)➕
assets/output/bin/uv(+0 -0)➕
assets/output/bin/uvx(+0 -0)➕
assets/output/lib/libpython3.12.dylib(+0 -0)➕
assets/output/lib/python3.12/lib-dynload/_crypt.cpython-312-darwin.so(+0 -0)➖
forge.config.ts(+0 -168)📝
scripts/signPython.sh(+2 -9)📝
scripts/todesktop/afterPack.js(+2 -60)📝
scripts/todesktop/beforeInstall.js(+7 -21)📝
scripts/todesktop/postInstall.js(+18 -45)📝
src/pythonEnvironment.ts(+17 -0)📝
todesktop.json(+11 -2)📄 Description
Running the Publish All Action will now build and send the files to ToDesktop, to be built into installers and staged waiting for deployment.
Deployment is executed on ToDesktop.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.