[PR #136] [MERGED] toDesktop Fixed Mac, Cleaned Up, Documented. #636

Closed
opened 2026-10-31 22:15:29 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/136
Author: @KenCorma
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @KenCorma

Base: main ← Head: dev-kendal-fix-mac


📝 Commits (5)

📊 Changes

16 files changed (+62 additions, -307 deletions)

View changed files

📝 .github/actions/build/windows/todesktop/action.yml (+2 -2)
📝 .github/workflows/publish_linux.yml (+1 -0)
📝 .github/workflows/publish_macos.yml (+1 -0)
📝 .github/workflows/publish_windows.yml (+1 -0)
➕ assets/output/bin/python3.12 (+0 -0)
➕ assets/output/bin/uv (+0 -0)
➕ assets/output/bin/uvx (+0 -0)
➕ assets/output/lib/libpython3.12.dylib (+0 -0)
➕ assets/output/lib/python3.12/lib-dynload/_crypt.cpython-312-darwin.so (+0 -0)
➖ forge.config.ts (+0 -168)
📝 scripts/signPython.sh (+2 -9)
📝 scripts/todesktop/afterPack.js (+2 -60)
📝 scripts/todesktop/beforeInstall.js (+7 -21)
📝 scripts/todesktop/postInstall.js (+18 -45)
📝 src/pythonEnvironment.ts (+17 -0)
📝 todesktop.json (+11 -2)

📄 Description

Running the Publish All Action will now build and send the files to ToDesktop, to be built into installers and staged waiting for deployment.

Deployment is executed on ToDesktop.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/136 **Author:** [@KenCorma](https://github.com/KenCorma) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@KenCorma](https://github.com/KenCorma) **Base:** `main` ← **Head:** `dev-kendal-fix-mac` --- ### 📝 Commits (5) - [`4aca6b1`](https://github.com/Comfy-Org/desktop/commit/4aca6b16cfb0638562cac0d50250e2e37e0699dd) Just upload these files - [`29b0e04`](https://github.com/Comfy-Org/desktop/commit/29b0e04a3cbcab98ad5a78d5c323275164361ac1) This should fix the issue - [`b877505`](https://github.com/Comfy-Org/desktop/commit/b8775051fbb8184f106976d068f0e62893cf90a9) Cleaned up and added Documentation - [`dea06f3`](https://github.com/Comfy-Org/desktop/commit/dea06f3c21694e1299f18c765ba377ec0bb99f2b) Format Fix - [`3e368c1`](https://github.com/Comfy-Org/desktop/commit/3e368c195ac6726b28111b61e721a4cee01fc4dc) Bumped up Icon size ### 📊 Changes **16 files changed** (+62 additions, -307 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/windows/todesktop/action.yml` (+2 -2) 📝 `.github/workflows/publish_linux.yml` (+1 -0) 📝 `.github/workflows/publish_macos.yml` (+1 -0) 📝 `.github/workflows/publish_windows.yml` (+1 -0) ➕ `assets/output/bin/python3.12` (+0 -0) ➕ `assets/output/bin/uv` (+0 -0) ➕ `assets/output/bin/uvx` (+0 -0) ➕ `assets/output/lib/libpython3.12.dylib` (+0 -0) ➕ `assets/output/lib/python3.12/lib-dynload/_crypt.cpython-312-darwin.so` (+0 -0) ➖ `forge.config.ts` (+0 -168) 📝 `scripts/signPython.sh` (+2 -9) 📝 `scripts/todesktop/afterPack.js` (+2 -60) 📝 `scripts/todesktop/beforeInstall.js` (+7 -21) 📝 `scripts/todesktop/postInstall.js` (+18 -45) 📝 `src/pythonEnvironment.ts` (+17 -0) 📝 `todesktop.json` (+11 -2) </details> ### 📄 Description Running the Publish All Action will now build and send the files to ToDesktop, to be built into installers and staged waiting for deployment. Deployment is executed on ToDesktop. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:15:29 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#636
No description provided.