[PR #983] [MERGED] [Test] Improve test isolation and readability #1258

New issue

Closed

opened 2026-10-31 22:20:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/983
Author: @webfiltered
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/23/2025
Merged by: @webfiltered

Base: main ← Head: test-desktopapp

📝 Commits (6)

02d069d [Test] AI extend conversion - Partial
4bdd6a0 [Test] Improve test isolation and readability
be01d97 [Cleanup] Remove redundant code
929e0b5 [Test] Prefer fixtures over loose variables
ec94a62 Add install failure fixture
8b01a4d [Test] Add InstallationManager fixture

📊 Changes

2 files changed (+170 additions, -151 deletions)

View changed files

📝 src/infrastructure/interfaces.ts (+12 -0)
📝 tests/unit/desktopApp.test.ts (+158 -151)

📄 Description

Refactors to test.extend API.

Improves tests:

Resilience
Isolation
Readability
Reusability

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/983 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/23/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `test-desktopapp` --- ### 📝 Commits (6) - [`02d069d`](https://github.com/Comfy-Org/desktop/commit/02d069de06332858a33e7ed7ba34c6518f1fe806) [Test] AI extend conversion - Partial - [`4bdd6a0`](https://github.com/Comfy-Org/desktop/commit/4bdd6a09368d63dd7bdaa24d36add06543db9f20) [Test] Improve test isolation and readability - [`be01d97`](https://github.com/Comfy-Org/desktop/commit/be01d97325c329eba0cf3e7d30f3c08bb23de322) [Cleanup] Remove redundant code - [`929e0b5`](https://github.com/Comfy-Org/desktop/commit/929e0b5d353584a6adfae362f6b5bed9b8499eed) [Test] Prefer fixtures over loose variables - [`ec94a62`](https://github.com/Comfy-Org/desktop/commit/ec94a62b4a9214998e1e1235b9cdb15105a30936) Add install failure fixture - [`8b01a4d`](https://github.com/Comfy-Org/desktop/commit/8b01a4d158ad0c86b35be69557c1573aacb48e95) [Test] Add InstallationManager fixture ### 📊 Changes **2 files changed** (+170 additions, -151 deletions) <details> <summary>View changed files</summary> 📝 `src/infrastructure/interfaces.ts` (+12 -0) 📝 `tests/unit/desktopApp.test.ts` (+158 -151) </details> ### 📄 Description Refactors to `test.extend` API. Improves tests: - Resilience - Isolation - Readability - Reusability ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-983-Test-Improve-test-isolation-and-readability-1a36d73d365081f882e3e8ca3574187d) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:52 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:21 +00:00

[PR #1258] [MERGED] Update ComfyUI core to v0.3.51 #1437

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1258

No description provided.

Rows
Columns