[PR #638] [MERGED] Sort imports with prettier #983

New issue

Closed

opened 2026-10-31 22:18:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/638
Author: @huchenlei
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @huchenlei

Base: main ← Head: sort_imports

📝 Commits (5)

d0b619a Sort imports with prettier
5997b00 sort imports
0e6ec20 Add as dev dependency
8c3315a Apply separation
311a2dd nit

📊 Changes

44 files changed (+242 additions, -123 deletions)

View changed files

📝 .prettierrc (+10 -0)
📝 eslint.config.js (+2 -2)
📝 infrastructure/viteElectronAppPlugin.ts (+4 -2)
📝 package.json (+1 -0)
📝 scripts/downloadUV.js (+5 -4)
📝 scripts/launchCI.js (+1 -1)
📝 scripts/makeComfy.js (+2 -1)
📝 scripts/preMake.js (+1 -1)
📝 scripts/prepareTypes.js (+1 -0)
📝 scripts/resetInstall.js (+2 -2)
📝 src/config/comfyConfigManager.ts (+1 -1)
📝 src/config/comfyServerConfig.ts (+3 -3)
📝 src/config/comfySettings.ts (+1 -1)
📝 src/handlers/appInfoHandlers.ts (+2 -1)
📝 src/handlers/pathHandlers.ts (+5 -4)
📝 src/install/installWizard.ts (+5 -4)
📝 src/install/installationManager.ts (+6 -5)
📝 src/main-process/appWindow.ts (+12 -11)
📝 src/main-process/comfyDesktopApp.ts (+15 -14)
📝 src/main-process/comfyInstallation.ts (+3 -2)

...and 24 more files

📄 Description

Sync the configuration from https://github.com/Comfy-Org/ComfyUI_frontend/pull/2104

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/638 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `sort_imports` --- ### 📝 Commits (5) - [`d0b619a`](https://github.com/Comfy-Org/desktop/commit/d0b619ac0855f354a594dd0dbeb83cf7fbb21623) Sort imports with prettier - [`5997b00`](https://github.com/Comfy-Org/desktop/commit/5997b0030b5a5b8ee3f8b97a6f2c5eec458bfc88) sort imports - [`0e6ec20`](https://github.com/Comfy-Org/desktop/commit/0e6ec20f3f8375f08761cc8d5bd33288e10092a8) Add as dev dependency - [`8c3315a`](https://github.com/Comfy-Org/desktop/commit/8c3315a19e52105260a21d55700d11f44aa62e48) Apply separation - [`311a2dd`](https://github.com/Comfy-Org/desktop/commit/311a2dd2cbd8fdd1a9b61e5ab95c4d2d5e6af4a9) nit ### 📊 Changes **44 files changed** (+242 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `.prettierrc` (+10 -0) 📝 `eslint.config.js` (+2 -2) 📝 `infrastructure/viteElectronAppPlugin.ts` (+4 -2) 📝 `package.json` (+1 -0) 📝 `scripts/downloadUV.js` (+5 -4) 📝 `scripts/launchCI.js` (+1 -1) 📝 `scripts/makeComfy.js` (+2 -1) 📝 `scripts/preMake.js` (+1 -1) 📝 `scripts/prepareTypes.js` (+1 -0) 📝 `scripts/resetInstall.js` (+2 -2) 📝 `src/config/comfyConfigManager.ts` (+1 -1) 📝 `src/config/comfyServerConfig.ts` (+3 -3) 📝 `src/config/comfySettings.ts` (+1 -1) 📝 `src/handlers/appInfoHandlers.ts` (+2 -1) 📝 `src/handlers/pathHandlers.ts` (+5 -4) 📝 `src/install/installWizard.ts` (+5 -4) 📝 `src/install/installationManager.ts` (+6 -5) 📝 `src/main-process/appWindow.ts` (+12 -11) 📝 `src/main-process/comfyDesktopApp.ts` (+15 -14) 📝 `src/main-process/comfyInstallation.ts` (+3 -2) _...and 24 more files_ </details> ### 📄 Description Sync the configuration from https://github.com/Comfy-Org/ComfyUI_frontend/pull/2104 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-638-Sort-imports-with-prettier-17d6d73d3650817cb4d1c36933423a85) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:31 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:52 +00:00

[PR #983] [MERGED] [Test] Improve test isolation and readability #1258

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#983

No description provided.

Rows
Columns